From: John Keeping <john@keeping.me.uk>
To: Gianni Ceccarelli <dakkar@thenautilus.net>
Cc: cgit@lists.zx2c4.com
Subject: Re: Weird interactions betwen cache and module-link
Date: Sat, 26 Mar 2022 10:30:41 +0000 [thread overview]
Message-ID: <Yj7rUSsNZ2XsDTqx@keeping.me.uk> (raw)
In-Reply-To: <20220325214448.244a6590@thenautilus.net>
On Fri, Mar 25, 2022 at 09:44:48PM +0000, Gianni Ceccarelli wrote:
> This patch seems to fix the problem.
Nice catch! This definitely looks like an oversight.
Would you like to type up a proper patch with a commit message and
Signed-off-by certification? We use the same process as git.git so
their SubmittingPatches document [1] explains this.
[1] https://git-scm.com/docs/SubmittingPatches#sign-off
> diff --git c/cgit.c w/cgit.c
> index 08d81a1..d30e259 100644
> --- c/cgit.c
> +++ w/cgit.c
> @@ -810,6 +810,10 @@ static void print_repo(FILE *f, struct cgit_repo *repo)
> fprintf(f, "repo.extra-head-content=%s\n", repo->extra_head_content);
> if (repo->module_link)
> fprintf(f, "repo.module-link=%s\n", repo->module_link);
> + for (int i = 0; i < repo->submodules.nr; ++i) {
> + struct string_list_item *si=&repo->submodules.items[i];
> + fprintf(f, "repo.module-link.%s=%s\n", si->string, (char*)si->util);
> + }
> if (repo->section)
> fprintf(f, "repo.section=%s\n", repo->section);
> if (repo->homepage)
>
>
> --
> Dakkar - <Mobilis in mobile>
> GPG public key fingerprint = A071 E618 DD2C 5901 9574
> 6FE2 40EA 9883 7519 3F88
> key id = 0x75193F88
>
next prev parent reply other threads:[~2022-03-26 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 21:08 Gianni Ceccarelli
2022-03-25 21:44 ` Gianni Ceccarelli
2022-03-26 10:30 ` John Keeping [this message]
2022-03-26 10:44 ` Gianni Ceccarelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj7rUSsNZ2XsDTqx@keeping.me.uk \
--to=john@keeping.me.uk \
--cc=cgit@lists.zx2c4.com \
--cc=dakkar@thenautilus.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).