From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 32709 invoked from network); 26 Mar 2022 10:31:00 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 26 Mar 2022 10:31:00 -0000 Received: by lists.zx2c4.com (OpenSMTPD) with ESMTP id 558f6a7a; Sat, 26 Mar 2022 10:30:47 +0000 (UTC) Return-Path: Received: from mta01.prd.rdg.aluminati.org (mta01.prd.rdg.aluminati.org [94.76.243.214]) by lists.zx2c4.com (OpenSMTPD) with ESMTPS id 6a92aa9c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Sat, 26 Mar 2022 10:30:46 +0000 (UTC) Received: from mta01.prd.rdg.aluminati.org (localhost [127.0.0.1]) by mta.aluminati.local (Postfix) with ESMTP id 34B4EC0022; Sat, 26 Mar 2022 10:30:46 +0000 (GMT) Received: from localhost (localhost [127.0.0.1]) by mta01.prd.rdg.aluminati.org (Postfix) with ESMTP id 2E5A0203CC; Sat, 26 Mar 2022 10:30:46 +0000 (GMT) X-Quarantine-ID: X-Virus-Scanned: Debian amavisd-new at mta01.prd.rdg.aluminati.org Received: from mta.aluminati.local ([127.0.0.1]) by localhost (mta01.prd.rdg.aluminati.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pcPUx_lkmCy1; Sat, 26 Mar 2022 10:30:44 +0000 (GMT) Received: from keeping.me.uk (unknown [81.174.171.191]) by svc01-1.prd.rdg.aluminati.org (Postfix) with ESMTPSA id 1DF911C0002; Sat, 26 Mar 2022 10:30:42 +0000 (GMT) Date: Sat, 26 Mar 2022 10:30:41 +0000 From: John Keeping To: Gianni Ceccarelli Cc: cgit@lists.zx2c4.com Subject: Re: Weird interactions betwen cache and module-link Message-ID: References: <20220325210816.6f89abb3@thenautilus.net> <20220325214448.244a6590@thenautilus.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220325214448.244a6590@thenautilus.net> X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" On Fri, Mar 25, 2022 at 09:44:48PM +0000, Gianni Ceccarelli wrote: > This patch seems to fix the problem. Nice catch! This definitely looks like an oversight. Would you like to type up a proper patch with a commit message and Signed-off-by certification? We use the same process as git.git so their SubmittingPatches document [1] explains this. [1] https://git-scm.com/docs/SubmittingPatches#sign-off > diff --git c/cgit.c w/cgit.c > index 08d81a1..d30e259 100644 > --- c/cgit.c > +++ w/cgit.c > @@ -810,6 +810,10 @@ static void print_repo(FILE *f, struct cgit_repo *repo) > fprintf(f, "repo.extra-head-content=%s\n", repo->extra_head_content); > if (repo->module_link) > fprintf(f, "repo.module-link=%s\n", repo->module_link); > + for (int i = 0; i < repo->submodules.nr; ++i) { > + struct string_list_item *si=&repo->submodules.items[i]; > + fprintf(f, "repo.module-link.%s=%s\n", si->string, (char*)si->util); > + } > if (repo->section) > fprintf(f, "repo.section=%s\n", repo->section); > if (repo->homepage) > > > -- > Dakkar - > GPG public key fingerprint = A071 E618 DD2C 5901 9574 > 6FE2 40EA 9883 7519 3F88 > key id = 0x75193F88 >