From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11049 invoked from network); 6 Mar 2023 11:41:43 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 6 Mar 2023 11:41:43 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 4f979cfa; Mon, 6 Mar 2023 11:41:26 +0000 (UTC) Return-Path: Received: from mta01.prd.rdg.aluminati.org (mta01.prd.rdg.aluminati.org [94.76.243.214]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 92d5214a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Mon, 6 Mar 2023 11:41:22 +0000 (UTC) Received: from mta01.prd.rdg.aluminati.org (localhost [127.0.0.1]) by mta.aluminati.local (Postfix) with ESMTP id 48E2CBF147; Mon, 6 Mar 2023 11:41:22 +0000 (GMT) Received: from localhost (localhost [127.0.0.1]) by mta01.prd.rdg.aluminati.org (Postfix) with ESMTP id 3507720FBB; Mon, 6 Mar 2023 11:41:22 +0000 (GMT) X-Quarantine-ID: X-Virus-Scanned: Debian amavisd-new at mta01.prd.rdg.aluminati.org Received: from mta.aluminati.local ([127.0.0.1]) by localhost (mta01.prd.rdg.aluminati.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ms9-I5oDkF2X; Mon, 6 Mar 2023 11:41:21 +0000 (GMT) Received: from keeping.me.uk (unknown [81.174.171.191]) by svc01-1.prd.rdg.aluminati.org (Postfix) with ESMTPSA id 2D9501C0003; Mon, 6 Mar 2023 11:41:19 +0000 (GMT) Date: Mon, 6 Mar 2023 11:41:18 +0000 From: John Keeping To: Andreas Mahling Cc: cgit@lists.zx2c4.com Subject: Re: cgit with busybox httpd Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" On Mon, Mar 06, 2023 at 11:13:10AM +0100, Andreas Mahling wrote: > I'm in the process to configure a cgit instance for my private network at home. > Because my internet router will be the host for git and cgit, I'm > looking for a ligthweight setup. > I would like to use busybox httpd as webserver, which has a very low > footprint and supports cgi, but no other fancy bells and whistles, > especially no url rewrite. > > It works in principle, but there is a problem with the URLs generated > by cgit: they seem always containing a trailing slash. This leads to a > 404 error thrown by httpd. If I manually remove the slash, everyting > is OK. > > Example given: > http://git/cgi-bin/cgit.cgi/linuxadmin.git/ -> 404 > http://git/cgi-bin/cgit.cgi/linuxadmin.git -> Page ist shown > > Is there a way to tell cgit to give up the trailing slash? I'm running > cgit-1.2.3-r3 on Alpine 3.17.2 I don't think it's possible to change that behaviour without patching CGit. Given how URLs are constructed, it looks a bit complicated to fix in all cases, but you could remove the setting of "virtual_root" in cmd_main() to force using query parameters instead of virtual paths in URLs. Can you tell where the 404 is generated? Is this a case of httpd returning an error when it shouldn't, or is it a behaviour difference that CGit isn't handling correctly - maybe other CGI hosts strip trailing slashes before passing a path to CGit but httpd doesn't?