From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 28336 invoked from network); 1 Jul 2023 06:29:01 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 1 Jul 2023 06:29:01 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 7955d31a; Sat, 1 Jul 2023 06:28:44 +0000 (UTC) Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id fd7bb090 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sat, 1 Jul 2023 06:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.com; s=s31663417; t=1688192923; x=1688797723; i=dlcampbell@gmx.com; bh=OF6OR8rMf8Qsj6O+hlx496ZGejhq6+rAaeB1AMlEX+I=; h=X-UI-Sender-Class:Date:From:To:Subject:References:In-Reply-To; b=U/2ikokX/gbhKVxPqSwFIts3PVHdB9YJA+oSGU1zsBSnMRgHkFi6rXvNLOgzLTBH6cYxhxA tzSWHN0jtO1ZKpoYqhBOezJg6Esz3EWs56PfAye72vVcHuj+OSXQfykUFwTiuUECYv7nwETwM OJOxZ0UE76LBMnhGymBI40tjFDxk/mQ1wdeIzLcyvDV6dMp/AqDLiFnAk3sDhH8NNt0A8+Fno p/JNk1TB9adk+39ABSbGFwHcrP8rOMcGvuP8ZVFhLQQNIFQX2kvyvdgEJ4NPaWTL+tdYJpAWI Jtrmw2MHS9rPQwLPBf8pRuSf703/nFnhE5f0ZIhMjVxd5LlQabjw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from koholint ([73.11.149.179]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MWAOQ-1qYisC3fnG-00XZSI for ; Sat, 01 Jul 2023 08:28:43 +0200 Date: Fri, 30 Jun 2023 23:28:39 -0700 From: Daniel Campbell To: cgit@lists.zx2c4.com Subject: Re: Follow-up: User-configurable log graph option Message-ID: References: <20210218223126.yrgfjni73fi4rvw4@frisbee> <20211230210820.3ncgngexbbhlpbdq@frisbee.local> <276a46560391a10194d808f6631b0c8612f0741e.camel@kasad.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <276a46560391a10194d808f6631b0c8612f0741e.camel@kasad.com> X-Provags-ID: V03:K1:kSSzp5I/7WV+chv5bvVtsY+zwqIPkAPni6vbqTevUBEDwWEd3bw uj2PDLOW+KUl11kAbbGoWYW4Ih99I/3xMrAz7rxsDTlHW6Y/qgA56azjdNjUKBDfLYLjAua aYaNIXnvzCjp/FNEDGdYU4LyXf2Y5lcNsN3Ce5YDe1rG7wKeXJCYLiR1yUcOWeHpZET5Xby oZWXwDv0rvMD/iXkLoDrA== UI-OutboundReport: notjunk:1;M01:P0:C4Fua3q3MS4=;0V995fpEIbPFS3chpfJzlfLEJCy vPrAi71FDdngMtmofeLndr3HruwamU1AYs58YJUV0O4COdJvX8ilaPdSHUABCAW2G9orQ0eCt xtz15fK1/b70VYhHh0Nq6iCRoagRnBf+/BsJLSjDW7CzSsVDbE1G34gdBY/DWRmoHhLPo9KFa 1q5mhdtEPGjH5zvpz8TOQ8x284e6E9VaWauFza4gRJ8lyRGeKIrTc6szAtZqdOTYdUOjBvAqM KYFIiGB0mFZuJrjSG/VSgHwQbUYtdu/eN5i4MvXSpEav+0psGY3+SzDxpMo/ZRphrIW61lIv8 7gLKLIOCtjIeCmcqrSTqWa/qBndcfHMxMvUf+kJrv113xaD04f0ClFld3RkijXeUUzdOs8GoX xmYgdKJ42somGGXqluCwadYbcz7Y8JD2fucvSwr2cJGDzuCXL40JwiYiqKXbIKa3ZH6gAh9Y9 9ozjjj+pkPCLHLfvCpivPT2YdmFxSePTBz/2mdeokZvb6JOXrR6ymMufbrtlqQVgc/Hd/3wyV hLT++2fY5vr2odwS6vpJhsqvE+XhS4+Tq4L/MyYrRNYIKFOMLsEmvX+e4WLYu5Q7N8Lvk10cC bAcwHlsX/5ifm5orqB24UYS0n5HGyZbNbLA717VrtQwb+o7fehhGf4F3zZtspjcv8XKKxZCK7 jo/vC0HEYnYnBYxopVQV/7q8pHBpP78zEmlse8Yd7jImCmXMSPkbJH4SXTKD/7M3UG0C5+aTv 49UFWufZz/TYRl/qq+fSNbnXyoZd6B2QJexiVsALTGnjNIylqFHuCKzV5q7OyrzTb6HR8980f 8FnmGnQKfmSjdqEnvQ5bgmj8m+GederUmiCRdHTiP9GYVko7kBag8rdztA+4qg1+dz190kJe7 aKrRm+mExgZjvfB8MaN1y+oKP29pAo9SWpbBwKxLu3TY7quhER5Sx2Kr39wCw3LFhJUj2EVv7 Il8afg== Content-Transfer-Encoding: quoted-printable X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" On Thu, Jan 05, 2023 at 03:14:42PM -0800, Kian Kasad wrote: > Hello cgit developers, > > Just over a year ago, I proposed a configurable "graph" option for the > log page. The idea was met with positive feedback, but when I proposed > my implementation I never heard back. So I'm trying again in hopes that > I can get a response. It would be nice if this was merged into the > upstream so I don't have to maintain my fork, but if the way I've > chosen to go about it isn't desirable, then I understand. But even in > the latter case, I need a "no" so I know to stop trying to push this. > > The original conversation is below. I've also finished the > implementation and am using it at https://git.kasad.com if you'd like > to test it out. > > See here for my fork of cgit implementing this change: > https://git.kasad.com/cgit/log/?h=3Dfeat%2Fgraph-page > > On Thu, 2021-12-30 at 13:08 -0800, Kian Kasad wrote: > > On 21/02/19 12:22PM, John Keeping wrote: > > > On Thu, Feb 18, 2021 at 02:31:26PM -0800, Kian Kasad wrote: > > > > I'm using cgit on my website and I'm wondering if it's possible > > > > to allow > > > > the user (i.e. the person visiting the site) to choose whether or > > > > not > > > > the commit graph is displayed on the log page. > > > > > > > > If this isn't currently possible, what do you think about adding > > > > such > > > > functionality? Maybe something like how the diff page lets the > > > > user > > > > choose between a "unified diff" and "ssdiff". > > > > > > This sounds like a great new feature! > > > > > > I think we still want to allow the administrator to turn the > > > feature > > > on/off but if it is permitted, then it makes sense to allow the end > > > user > > > to choose whether or not they want it enabled. > > > > Following up on this as I'm finally getting around to implementing > > this > > feature. I'm not too familiar with CGit's codebase, so I think it > > would > > be easier to implement this as a separate "graph" page which is > > identical to the log page except that it always displays a graph. > > > > This graph page would only be shown in the navbar's tab list if the > > "enable-commit-graph" option is set to "separate" in the > > configuration. > > If it is set to "combined" then the graph page will be disabled and > > the > > commit graph will be displayed on the log page as it currently is > > when > > the "enable-commit-graph" option is set to "1". > > > > In order to maintain backwards compatibility, the value "1" could > > also > > be interpreted as the value "combined" since it has the same > > functionality currently. > > > > The value "none" (or "0" for backwards compatibility) would disable > > the > > graph page as well as disabling the commit graph on the log page. > > > > I've already started working on this as I want it for my own CGit > > site. > > If this is something that the maintainer(s) want to integrate, I'll > > send > > patches when I'm done. > > -- > Kian Kasad > PGP 0x1715EEAA14DAEC1 > kian@kasad.com > (925) 871-9823 Hi! I'm not a regular developer of cgit, so I can't make any claims regarding whether it's suitable for merge, but I took some time to check out your cgit instance. I encountered some difficulty fully understanding what your patchset did, until I looked at the links and played around a little. Your graph page's "Expand" and "Collapse" links are pointing to the log page. I have to navigate *back* to /graph/ with the ?showmsg=3D1 GET data to see the commit-graph's pipes (indicating linear history in most repositories, as expected), and Collapse will remove the GET data, but bump me back over to the log page. I also looked around your instance trying to find a repository with a complex commit graph so I could better visualize your work. Can you recommend one to look at? The feature sounds interesting but there is trouble getting to it for now. The graph page still shows the Age column, but the column data is the commit date. Is it possible to modify column headers without having to duplicate the log page's code? Less a direct question, just something to ponder. It may be necessary, if the graph page's features diverge too far from what the log page currently offers. I think this feature could be handy, especially for projects with complex commit graphs. To be more explicit, I would: * find a way to get the expand and collapse links to stay on the graph page, so the new code is triggered. * change "Age" to "Date" in the first column header of the graph page If I understand correctly, the graph page is only accessible when the option is set to 'separate'. Assuming your instance is using this setting, is there any major difference between what we see on your instance, and the 'combined' setting? I am imagining that the log page just takes on the commit graph settings and the graph tab disappears. Is the column that holds dates still labeled 'Age' in that mode? Maybe it's not considered major enough to worry about -- age and date both having to do with time -- but it may also point to a need for a graph page to be distinct flavor of the log page's code. It'd be best to defer to cgit devs on this particular decision. Being its own page seems better imo. Please let me know if I've misunderstood something or am unclear. It's been a while since I've reviewed code and I mean no offense or insult. ~Daniel