From: roy at marples.name (Roy Marples)
Subject: [PATCH] filter: set environment variable PYTHONIOENCODING to utf-8
Date: Mon, 6 Mar 2017 09:14:14 +0000 [thread overview]
Message-ID: <a0fee989-fd43-227e-756d-00dd37ed30ff@marples.name> (raw)
In-Reply-To: <20170304123521.GC2102@john.keeping.me.uk>
On 04/03/2017 12:35, John Keeping wrote:
> On Thu, Feb 23, 2017 at 03:48:23PM +0000, Roy Marples wrote:
>> This allows different versions of Python to be used rather than
>> forcing version specific encoding in each script.
>>
>> Signed-off-by: Roy Marples <roy at marples.name>
>> ---
>> filter.c | 8 ++++++++
>> filters/email-gravatar.py | 3 ---
>> filters/syntax-highlighting.py | 5 +----
>> 3 files changed, 9 insertions(+), 7 deletions(-)
>
> Neat! This definitely makes writing it easier to get it right with
> Python filters, but having filter_env_set seems unnecessary.
>
> Is there a reason not to either:
>
> 1) set PYTHONIOENCODING unconditionally early in startup
>
> or
>
> 2) set the environment in the child after forking
No reason.
I went this approach so that it's only set once when needed, happy to
re-base my work with either of the two above options.
Roy
next prev parent reply other threads:[~2017-03-06 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 15:48 roy
2017-03-04 12:35 ` john
2017-03-06 9:14 ` roy [this message]
2017-03-08 19:01 ` roy
2017-03-09 0:10 ` john
2017-03-12 17:01 ` Jason
2017-03-12 17:51 ` john
2017-03-17 18:07 ` Jason
2017-03-17 20:04 ` john
2017-03-17 20:13 ` roy
2017-08-10 14:04 ` Jason
2017-03-09 0:18 roy
2017-03-10 15:28 ` john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0fee989-fd43-227e-756d-00dd37ed30ff@marples.name \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).