From: stefan at sevenbyte.org (Stefan Tatschner)
Subject: [PATCH] footer: link back to cgit home page
Date: Wed, 19 Mar 2014 12:08:38 +0100 [thread overview]
Message-ID: <a3ce1a21-f8b0-4166-81ec-b1befd2d6842@email.android.com> (raw)
In-Reply-To: <1395220457-1737-1-git-send-email-Jason@zx2c4.com>
I personally think it's ok.
On March 19, 2014 10:14:17 AM CET, "Jason A. Donenfeld" <Jason at zx2c4.com> wrote:
>The footer has always been overrideable using the footer= in cgitrc, so
>this won't anger anybody who cares about their footer.
>---
>Is this horrible? Or is this acceptable?
>
> cgit.css | 7 +++++++
> ui-shared.c | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/cgit.css b/cgit.css
>index 71b0b9b..6888cde 100644
>--- a/cgit.css
>+++ b/cgit.css
>@@ -590,6 +590,13 @@ div#cgit div.footer {
> font-size: 80%;
> color: #ccc;
> }
>+div#cgit div.footer a {
>+ color: #ccc;
>+ text-decoration: none;
>+}
>+div#cgit div.footer a:hover {
>+ text-decoration: underline;
>+}
> div#cgit a.branch-deco {
> color: #000;
> margin: 0px 0.5em;
>diff --git a/ui-shared.c b/ui-shared.c
>index 1ede2b0..ba173f4 100644
>--- a/ui-shared.c
>+++ b/ui-shared.c
>@@ -719,7 +719,7 @@ void cgit_print_docend()
> if (ctx.cfg.footer)
> html_include(ctx.cfg.footer);
> else {
>- htmlf("<div class='footer'>generated by cgit %s at ",
>+ htmlf("<div class='footer'>generated by <a
>href='http://git.zx2c4.com/cgit/about/'>cgit %s</a> at ",
> cgit_version);
> cgit_print_date(time(NULL), FMT_LONGDATE, ctx.cfg.local_time);
> html("</div>\n");
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
prev parent reply other threads:[~2014-03-19 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 9:14 Jason
2014-03-19 11:08 ` stefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ce1a21-f8b0-4166-81ec-b1befd2d6842@email.android.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).