List for cgit developers and users
 help / color / mirror / Atom feed
Subject: Slash after /about
Date: Tue, 29 Jan 2019 09:21:01 +0000	[thread overview]
Message-ID: <b0bbc1d078f60c1bf0160d95a8f863946c574b0f.camel@aegee.org> (raw)

Hello,

For CGI I use thttpd and it tends to remove terminating slashes in the requests.

cgit wants to have slash after about/ .

So they do not work together, endless loop happens.  Proposed fix:

diff --git a/cmd.c b/cmd.c
--- a/cmd.c
+++ b/cmd.c
@@ -40,16 +40,7 @@ static void atom_fn(void)
 static void about_fn(void)
 {
        if (ctx.repo) {
-               size_t path_info_len = ctx.env.path_info ? strlen(ctx.env.path_info) : 0;
-               if (!ctx.qry.path &&
-                   ctx.qry.url[strlen(ctx.qry.url) - 1] != '/' &&
-                   (!path_info_len || ctx.env.path_info[path_info_len - 1] != '/')) {
-                       char *currenturl = cgit_currenturl();
-                       char *redirect = fmtalloc("%s/", currenturl);
-                       cgit_redirect(redirect, true);
-                       free(currenturl);
-                       free(redirect);
-               } else if (ctx.repo->readme.nr)
+               if (ctx.repo->readme.nr)
                        cgit_print_repo_readme(ctx.qry.path);
                else if (ctx.repo->homepage)
                        cgit_redirect(ctx.repo->homepage, false);



Apart of this the alphabetical sort order of the options in cgitrc.5 is violated by case-sensitive-sort, it shall not be
between cache-size and cache-scanrc-ttl .

Regards
  ?????



             reply	other threads:[~2019-01-29  9:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29  9:21  [this message]
2019-01-29 18:58 ` 
2019-01-30 17:53   ` Dilyan.Palauzov
2019-01-30 18:37 ` john

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0bbc1d078f60c1bf0160d95a8f863946c574b0f.camel@aegee.org \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).