List for cgit developers and users
 help / color / mirror / Atom feed
From: Alexander Pickering <alex@cogarr.net>
To: cgit@lists.zx2c4.com
Subject: Typo introduced #2f50b47
Date: Sat, 3 Aug 2024 16:52:06 -0500	[thread overview]
Message-ID: <b3aa8a4c-57c0-4e91-b6a5-688a66fbf401@cogarr.net> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 807 bytes --]

Hi all,

Thanks for cgit, it's great! I have cgit occasionally (re-)compiling on 
a Debian 11 system with gcc, today it errored in scan-tree.c on the 
master branch. My setup script is:

	git clone https://git.zx2c4.com/cgit
	cd cgit
	git submodule init
	git submodule update
	make
	make install


I got the error

	../scan-tree.c:57:65: error: parameter name omitted
    57 | ic int gitconfig_config(const char *key, const char *value,
		const struct config_context *, void *cb)

I think this line

	static int gitconfig_config(const char *key, const char *value, const 
struct config_context *, void *cb)

should be
	
	static int gitconfig_config(const char *key, const char *value, void *cb)

If I make this change, it compiles and seems to work as expected.

Best,
Alex

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

             reply	other threads:[~2024-08-03 21:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-03 21:52 Alexander Pickering [this message]
2024-08-04  3:01 ` Kian Kasad
2024-08-04  3:18   ` [PATCH] Fix error caused by missing parameter name Kian Kasad
2024-08-04  6:17     ` Денис Пронин
2024-08-04 18:43       ` [PATCH v2] " Kian Kasad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3aa8a4c-57c0-4e91-b6a5-688a66fbf401@cogarr.net \
    --to=alex@cogarr.net \
    --cc=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).