From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 3/8] Remove redundant includes
Date: Thu, 13 Aug 2015 12:14:15 +0100 [thread overview]
Message-ID: <c55e37c021aadeded24f0b9693fb0f820b66c0d2.1439464215.git.john@keeping.me.uk> (raw)
In-Reply-To: <cover.1439464215.git.john@keeping.me.uk>
These are all included in git-compat-util.h (when necessary), which we
include in cgit.h.
Signed-off-by: John Keeping <john at keeping.me.uk>
---
filter.c | 6 ------
html.c | 6 ------
shared.c | 1 -
ui-plain.c | 1 -
ui-repolist.c | 1 -
ui-summary.c | 1 -
6 files changed, 16 deletions(-)
diff --git a/filter.c b/filter.c
index ebf4937..c7037a3 100644
--- a/filter.c
+++ b/filter.c
@@ -8,13 +8,7 @@
#include "cgit.h"
#include "html.h"
-#include <sys/types.h>
-#include <sys/wait.h>
-#include <unistd.h>
-#include <string.h>
-#include <stdlib.h>
#include <dlfcn.h>
-#include <errno.h>
#ifndef NO_LUA
#include <lua.h>
#include <lualib.h>
diff --git a/html.c b/html.c
index 155cde5..a47cff0 100644
--- a/html.c
+++ b/html.c
@@ -8,12 +8,6 @@
#include "cgit.h"
#include "html.h"
-#include <unistd.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include <string.h>
-#include <errno.h>
/* Percent-encoding of each character, except: a-zA-Z0-9!$()*,./:;@- */
static const char* url_escape_table[256] = {
diff --git a/shared.c b/shared.c
index 0431b59..3bd2a9e 100644
--- a/shared.c
+++ b/shared.c
@@ -7,7 +7,6 @@
*/
#include "cgit.h"
-#include <stdio.h>
struct cgit_repolist cgit_repolist;
struct cgit_context ctx;
diff --git a/ui-plain.c b/ui-plain.c
index b787bc3..3a2cb47 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -6,7 +6,6 @@
* (see COPYING for full license text)
*/
-#include <stdio.h>
#include "cgit.h"
#include "ui-plain.h"
#include "html.h"
diff --git a/ui-repolist.c b/ui-repolist.c
index edefc4c..43253ed 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -10,7 +10,6 @@
#include "ui-repolist.h"
#include "html.h"
#include "ui-shared.h"
-#include <strings.h>
static time_t read_agefile(char *path)
{
diff --git a/ui-summary.c b/ui-summary.c
index b0af073..a5c7078 100644
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -13,7 +13,6 @@
#include "ui-refs.h"
#include "ui-blob.h"
#include "ui-shared.h"
-#include <libgen.h>
static int urls;
--
2.5.0.466.g9af26fa
next prev parent reply other threads:[~2015-08-13 11:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 11:14 [PATCH 0/8] Portability fixes john
2015-08-13 11:14 ` [PATCH 1/8] tests: allow shell to be overridden john
2015-08-13 11:14 ` [PATCH 2/8] Makefile: include Git's config.mak.uname john
2015-08-13 11:14 ` john [this message]
2015-08-13 13:36 ` [PATCH 3/8] Remove redundant includes Jason
2015-08-13 13:49 ` john
2015-08-20 13:51 ` mathstuf
2015-08-13 11:14 ` [PATCH 4/8] configfile.c: don't include system headers directly john
2015-08-13 11:14 ` [PATCH 5/8] cache.c: fix header order john
2015-08-13 11:14 ` [PATCH 6/8] cgit.h: move stdbool.h from ui-shared.h john
2015-08-13 11:14 ` [PATCH 7/8] ui-tree: use "sane" isgraph() john
2015-08-13 11:14 ` [PATCH 8/8] filter: don't use dlsym unnecessarily john
2015-08-13 13:38 ` [PATCH 0/8] Portability fixes Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c55e37c021aadeded24f0b9693fb0f820b66c0d2.1439464215.git.john@keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).