From mboxrd@z Thu Jan  1 00:00:00 1970
From: roy at marples.name (Roy Marples)
Date: Wed, 8 Mar 2017 19:01:59 +0000
Subject: [PATCH] filter: set environment variable PYTHONIOENCODING to utf-8
In-Reply-To: <a0fee989-fd43-227e-756d-00dd37ed30ff@marples.name>
References: <20170223154823.18206-1-roy@marples.name>
 <20170304123521.GC2102@john.keeping.me.uk>
 <a0fee989-fd43-227e-756d-00dd37ed30ff@marples.name>
Message-ID: <c6c11fd1-5903-7986-c5f8-f52747d8b1dc@marples.name>

On 06/03/2017 09:14, Roy Marples wrote:
> On 04/03/2017 12:35, John Keeping wrote:
>> On Thu, Feb 23, 2017 at 03:48:23PM +0000, Roy Marples wrote:
>>> This allows different versions of Python to be used rather than
>>> forcing version specific encoding in each script.
>>>
>>> Signed-off-by: Roy Marples <roy at marples.name>
>>> ---
>>>  filter.c                       | 8 ++++++++
>>>  filters/email-gravatar.py      | 3 ---
>>>  filters/syntax-highlighting.py | 5 +----
>>>  3 files changed, 9 insertions(+), 7 deletions(-)
>>
>> Neat!  This definitely makes writing it easier to get it right with
>> Python filters, but having filter_env_set seems unnecessary.
>>
>> Is there a reason not to either:
>>
>> 1) set PYTHONIOENCODING unconditionally early in startup
>>
>> or
>>
>> 2) set the environment in the child after forking
> 
> No reason.
> I went this approach so that it's only set once when needed, happy to
> re-base my work with either of the two above options.

Is there anything more you want me to do here?

Roy