List for cgit developers and users
 help / color / mirror / Atom feed
From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 1/2] t0109: refactor test code into a function
Date: Sun, 14 Apr 2013 17:07:41 +0100	[thread overview]
Message-ID: <cb27d4b69dce1c7e89702894b049dc647169b17a.1365955662.git.john@keeping.me.uk> (raw)

This will allow us to run this test for multiple URLs.

While doing this, also specify CGIT_CONFIG and QUERY_STRING when
invoking cgit under strace.

Signed-off-by: John Keeping <john at keeping.me.uk>
---
 tests/t0109-gitconfig.sh | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tests/t0109-gitconfig.sh b/tests/t0109-gitconfig.sh
index f64e691..31d18b5 100755
--- a/tests/t0109-gitconfig.sh
+++ b/tests/t0109-gitconfig.sh
@@ -9,17 +9,22 @@ test -n "$(which strace 2>/dev/null)" || {
 	exit
 }
 
-test_expect_success 'no access to $HOME' '
+test_no_home_access () {
 	non_existant_path="/path/to/some/place/that/does/not/possibly/exist"
 	while test -d "$non_existant_path"; do
 		non_existant_path="$non_existant_path/$(date +%N)"
-	done
+	done &&
+	CGIT_CONFIG="$(pwd)/cgitrc" QUERY_STRING="url=$1" \
 	strace \
 		-E HOME="$non_existant_path" \
 		-E CGIT_CONFIG="$PWD/cgitrc" \
 		-E QUERY_STRING="url=foo/commit" \
 		-e access -f -o strace.out cgit &&
 	test_must_fail grep "$non_existant_path" strace.out
+}
+
+test_expect_success 'no access to $HOME' '
+	test_no_home_access ""
 '
 
 test_done
-- 
1.8.2.694.ga76e9c3.dirty





             reply	other threads:[~2013-04-14 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-14 16:07 john [this message]
2013-04-14 16:07 ` [PATCH 2/2] t0109: test using multiple URLs john
2013-04-15 14:48 ` [PATCH 1/2] t0109: refactor test code into a function Jason
2013-04-15 14:56   ` john
2013-04-15 15:00     ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb27d4b69dce1c7e89702894b049dc647169b17a.1365955662.git.john@keeping.me.uk \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).