List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH] Use https for submodule
@ 2017-09-18 20:09 dan
  2017-09-19 19:18 ` john
  0 siblings, 1 reply; 3+ messages in thread
From: dan @ 2017-09-18 20:09 UTC (permalink / raw)


Signed-off-by: Daniel M. Weeks <dan at danweeks.net>
---
 .gitmodules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitmodules b/.gitmodules
index 1daea94..5c6ecb4 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,3 @@
 [submodule "git"]
-	url = git://git.kernel.org/pub/scm/git/git.git
+	url = https://git.kernel.org/pub/scm/git/git.git
 	path = git
-- 
Daniel M. Weeks


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Use https for submodule
  2017-09-18 20:09 [PATCH] Use https for submodule dan
@ 2017-09-19 19:18 ` john
  2017-09-19 19:59   ` i
  0 siblings, 1 reply; 3+ messages in thread
From: john @ 2017-09-19 19:18 UTC (permalink / raw)


Please make use of the commit message to explain why this is a good
change.

On Mon, Sep 18, 2017 at 04:09:53PM -0400, Daniel M. Weeks wrote:
> Signed-off-by: Daniel M. Weeks <dan at danweeks.net>

With a more comprehensive commit message,

Reviewed-by: John Keeping <john at keeping.me.uk>

> ---
>  .gitmodules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitmodules b/.gitmodules
> index 1daea94..5c6ecb4 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,3 +1,3 @@
>  [submodule "git"]
> -	url = git://git.kernel.org/pub/scm/git/git.git
> +	url = https://git.kernel.org/pub/scm/git/git.git
>  	path = git


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Use https for submodule
  2017-09-19 19:18 ` john
@ 2017-09-19 19:59   ` i
  0 siblings, 0 replies; 3+ messages in thread
From: i @ 2017-09-19 19:59 UTC (permalink / raw)


Like:
Using PKI via https to avoid MITM attacks on git submodule.

Regards
MonkZ

On 19.09.2017 21:18, John Keeping wrote:
> Please make use of the commit message to explain why this is a good
> change.
> 
> On Mon, Sep 18, 2017 at 04:09:53PM -0400, Daniel M. Weeks wrote:
>> Signed-off-by: Daniel M. Weeks <dan at danweeks.net>
> 
> With a more comprehensive commit message,
> 
> Reviewed-by: John Keeping <john at keeping.me.uk>
> 
>> ---
>>  .gitmodules | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.gitmodules b/.gitmodules
>> index 1daea94..5c6ecb4 100644
>> --- a/.gitmodules
>> +++ b/.gitmodules
>> @@ -1,3 +1,3 @@
>>  [submodule "git"]
>> -	url = git://git.kernel.org/pub/scm/git/git.git
>> +	url = https://git.kernel.org/pub/scm/git/git.git
>>  	path = git
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/cgit
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20170919/53e21270/attachment.asc>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-09-19 19:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-18 20:09 [PATCH] Use https for submodule dan
2017-09-19 19:18 ` john
2017-09-19 19:59   ` i

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).