From: john at keeping.me.uk (John Keeping)
Subject: [PATCH 00/13] Fixes for problems detected by Sparse
Date: Sun, 8 Mar 2015 16:32:14 +0000 [thread overview]
Message-ID: <cover.1425832128.git.john@keeping.me.uk> (raw)
Sparse[0] detects several potential problems in CGit, which are all
fixed by this set of patches. Most of these are style issues that are
correct either way (using integer zero as a NULL pointer), but I think
there is value in keeping the build clean of Sparse warnings.
[0] https://sparse.wiki.kernel.org/index.php/Main_Page
John Keeping (13):
Makefile: add a target to run CGit through sparse
Avoid non-ANSI function declarations
Avoid signed bitfields
scan-tree: make some variables 'static'
shared: make some variables 'static'
ui-log: make some variables 'static'
ui-repolist: make sortcolumn definitions 'static const'
ui-shared: make cgit_doctype 'static'
ui-stats: make cgit_period definitions 'static const'
ui-shared: avoid initializing static variable to zero
ui-shared: don't use an integer as a NULL pointer
cache: don't use an integer as a NULL pointer
html: avoid using a plain integer as a NULL pointer
Makefile | 3 +++
cache.c | 2 +-
cgit.c | 2 +-
cgit.mk | 9 ++++++++-
filter.c | 2 +-
html.c | 54 ++++++++++++++++++++++++++++++++----------------------
scan-tree.c | 4 ++--
shared.c | 4 ++--
ui-blob.c | 4 ++--
ui-diff.c | 4 ++--
ui-log.c | 2 +-
ui-refs.c | 4 ++--
ui-repolist.c | 10 +++++-----
ui-shared.c | 18 +++++++++---------
ui-ssdiff.c | 16 ++++++++--------
ui-stats.c | 14 +++++++-------
ui-stats.h | 2 +-
ui-summary.c | 2 +-
ui-tree.c | 4 ++--
19 files changed, 90 insertions(+), 70 deletions(-)
--
2.3.1.308.g754cd77
next reply other threads:[~2015-03-08 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 16:32 john [this message]
2015-03-08 16:32 ` [PATCH 01/13] Makefile: add a target to run CGit through sparse john
2015-03-08 16:32 ` [PATCH 02/13] Avoid non-ANSI function declarations john
2015-03-08 16:32 ` [PATCH 03/13] Avoid signed bitfields john
2015-03-08 16:32 ` [PATCH 04/13] scan-tree: make some variables 'static' john
2015-03-08 16:32 ` [PATCH 05/13] shared: " john
2015-03-08 16:32 ` [PATCH 06/13] ui-log: " john
2015-03-08 16:32 ` [PATCH 07/13] ui-repolist: make sortcolumn definitions 'static const' john
2015-03-08 16:32 ` [PATCH 08/13] ui-shared: make cgit_doctype 'static' john
2015-03-08 16:32 ` [PATCH 09/13] ui-stats: make cgit_period definitions 'static const' john
2015-03-08 16:32 ` [PATCH 10/13] ui-shared: avoid initializing static variable to zero john
2015-03-08 16:32 ` [PATCH 11/13] ui-shared: don't use an integer as a NULL pointer john
2015-03-08 16:32 ` [PATCH 12/13] cache: " john
2015-03-08 16:32 ` [PATCH 13/13] html: avoid using a plain " john
2015-03-09 16:41 ` [PATCH 00/13] Fixes for problems detected by Sparse Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1425832128.git.john@keeping.me.uk \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).