From: bbuhlig at codeaurora.org (bbuhlig at codeaurora.org)
Subject: Gerrit features and Docker based testing
Date: Thu, 19 Oct 2017 17:07:30 -0600 [thread overview]
Message-ID: <d839460c2eedd5f309184b3292304d76@codeaurora.org> (raw)
Hi, Cgit is frequently paired with Gerrit installations, so I have a
some Gerrit integration features I'd like to contribute. One is a Lua
authentication filter for Gerrit. Background is that Gerrit allows
different
users to have access to different repos, so in essence this auth filter
leverages the user's Gerrit login HTTP cookie to access the Gerrit REST
API,
which it uses to figure out whether the logged in user should have
access to
the particular repo.
Anyway, to help ensure it keeps working along with the Lua code itself,
I'd
ideally like to contribute some tests for it. But the environment those
tests would need to run in would be a bit complicated, in particular
needing:
(1) the auth filter's Lua package dependencies installed-
- specifically: crypto, ssl.https and ltn12
and,
(2) a test Gerrit instance configured that the filter could talk to,
- or a simple python/node.js based webserver that looks
sufficiently
like the part of the Gerrit REST API that the filter cares
about
An obvious way to define this environment would be a Dockerfile that the
"make test" command invokes Docker against. To enable people who don't
care
about the Gerrit auth-filter, the makefile could be setup to skip the
test
if Docker isn't installed on the build machine. But unless the cgit
maintainers were to trigger the tests in a build environment with Docker
available, the auth filter code would eventually get stale and break.
Assuming the above sounds reasonable and I provided said feature and
tests,
would it be possible for the cgit maintainers to generally have Docker
available when regularly running "make test"?
Or another option might be to leverage Travis CI to regularly kick off
cgit builds in a Docker environment that way, but doing that would tie
you
to Github in ways that you probably aren't now.
Appreciate comments. Thanks, -Blake
next reply other threads:[~2017-10-19 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 23:07 bbuhlig [this message]
2017-10-21 13:05 ` john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d839460c2eedd5f309184b3292304d76@codeaurora.org \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).