[PATCH] native inline gravatar

[andy at warmcat.com (Andy Green)]

On 07/04/2018 07:49 AM, Jason A. Donenfeld wrote:
> Sorry, but not a chance something like this can be accepted. This is
> exactly the reason we put the time into making the Lua scripting

No worries.

> support. Is your reason for implementing this C performance? In that
> case, could you send some performance metrics and some details about

The main idea this is part of is it should be possible to get rid of all 
the filters and still get the common functionality.

Currently this

https://warmcat.com/git/cgit/log

https://warmcat.com/git/cgit/tree/
https://warmcat.com/git/cgit/tree/shared.c


doesn't use any filters for syntax highlight and markdown render, it's 
all done in clientside JS.  The gravatar is done using this patch.

This of course is a big performance win on the server since no 
subprocesses spawned at all.  Even on large files on an Android tablet, 
it's quick.

Even line numbers for /tree/ are done clientside, not generated and sent 
from the server any more.  URLs are corrected in the markdown as in the 
previous series, but done clientside.

> your performance requirements on a given system? Considering the Lua
> crypto module links against OpenSSL, I'm pretty sure that its hashing
> performance will be considerably better the slow reference
> implementation in this patch [1].
> 
> [1] https://github.com/openssl/openssl/blob/master/crypto/md5/asm/md5-x86_64.pl

OpenSSL is accelerated for some things on some architectures, it's true. 
  If that was the actual problem that can be ported as a special case of 
x86_64.

-Andy