List for cgit developers and users
 help / color / mirror / Atom feed
From: andy at (Andy Green)
Subject: [PATCH] native inline gravatar
Date: Wed, 4 Jul 2018 08:00:26 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 07/04/2018 07:49 AM, Jason A. Donenfeld wrote:
> Sorry, but not a chance something like this can be accepted. This is
> exactly the reason we put the time into making the Lua scripting

No worries.

> support. Is your reason for implementing this C performance? In that
> case, could you send some performance metrics and some details about

The main idea this is part of is it should be possible to get rid of all 
the filters and still get the common functionality.

Currently this

doesn't use any filters for syntax highlight and markdown render, it's 
all done in clientside JS.  The gravatar is done using this patch.

This of course is a big performance win on the server since no 
subprocesses spawned at all.  Even on large files on an Android tablet, 
it's quick.

Even line numbers for /tree/ are done clientside, not generated and sent 
from the server any more.  URLs are corrected in the markdown as in the 
previous series, but done clientside.

> your performance requirements on a given system? Considering the Lua
> crypto module links against OpenSSL, I'm pretty sure that its hashing
> performance will be considerably better the slow reference
> implementation in this patch [1].
> [1]

OpenSSL is accelerated for some things on some architectures, it's true. 
  If that was the actual problem that can be ported as a special case of 


  reply	other threads:[~2018-07-04  0:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-01  3:20 andy
2018-07-03 23:49 ` Jason
2018-07-04  0:00   ` andy [this message]
2018-07-04  0:14     ` Jason
2018-07-04  0:28       ` andy
2018-07-04  0:34         ` Jason
2018-07-04  0:44           ` andy
2018-07-04  1:05             ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).