List for cgit developers and users
 help / color / mirror / Atom feed
From: mathstuf at gmail.com (Ben Boeckel)
Subject: [PATCH] Makefile: improve dependency generation
Date: Sat, 17 Nov 2012 16:16:23 +0000 (UTC)	[thread overview]
Message-ID: <k88d8n$aci$1@ger.gmane.org> (raw)
In-Reply-To: <CAH-DoZ7r0KoEcpyHEi0LHjawec0dc9A8oEvzbRL9OAUsEaYdpQ@mail.gmail.com>

On Thu, Nov 15, 2012 at 03:40:52 GMT, Jamie Couture wrote:
> rpmbuild will strip (debugging) symbols.  I'm not sure about deb packaging;
> I'm also not sure about *bsd.  Regardless, I'll remove the append
> condition, +=
>
> CFLAGS = [default options]

No, please keep the '+='. RPM (and other tools I imagine) set CFLAGS in
the environment and usually pass them to make as well for Makefile-only
projects and expect the build system to use those as well. Fedora passes
-O2, so it should still get a release build (with debugging
information).

--Ben





  reply	other threads:[~2012-11-17 16:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15  0:46 jamie.couture
2012-11-15  0:57 ` Jason
2012-11-15  3:40   ` jamie.couture
2012-11-17 16:16     ` mathstuf [this message]
2012-11-17 16:17       ` Jason
2012-11-17 16:28         ` mathstuf
2012-11-17 18:02           ` [PATCH v5] " jamie.couture
2012-11-17 18:37             ` Jason
2012-11-15  4:24 ` [PATCH v2] " jamie.couture
2012-11-15  4:30   ` jamie.couture
2012-11-15  4:30 ` [PATCH v3] " jamie.couture
2012-11-15 23:48 ` [PATCH v4] " jamie.couture

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='k88d8n$aci$1@ger.gmane.org' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).