List for cgit developers and users
 help / color / mirror / Atom feed
From: jugg at hotmail.com (chris)
Subject: [PATCH] guess default branch from HEAD
Date: Tue, 19 Jul 2011 10:13:54 +0000 (UTC)	[thread overview]
Message-ID: <loom.20110719T120142-766@post.gmane.org> (raw)
In-Reply-To: <20110719095607.GC16136@hjemli.net>

 <larsh at ...> writes:
> On Tue, Jul 19, 2011 at 09:35:42AM +0000, chris wrote:
> > Should guess_defbranch() be called here instead of hard-coding "master"?
> 
> I don't think so, due to performance concerns (as explained earlier in this
> thread). It's a compromise, favoring performance over correctness.

Well, it sounds like premature optimization to me.  I wonder how much 
performance impact that would really have, and if cgit's caching support doesn't 
negate any potential issue on busy servers anyway.

I would expect correctness in user experience first.  If correctness is shown to 
impact performance, I would expect solutions/compromises in those specific cases 
as needed.

Of course I'm free to patch it to my liking obviously.  This is just some user 
feedback for you.

Thanks!

chris





  reply	other threads:[~2011-07-19 10:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 16:03 [PATCH 1/5] " plenz
2011-03-10 16:03 ` [PATCH 2/5] get_commit_date() obtains newest commit date plenz
2011-03-10 16:03 ` [PATCH 3/5] make enable-log-linecount independent of -filecount plenz
2011-03-10 17:25   ` hjemli
2011-03-26 14:43     ` hjemli
2011-03-10 16:03 ` [PATCH 4/5] fix two encoding bugs plenz
2011-03-10 17:29   ` hjemli
2011-03-10 16:03 ` [PATCH 5/5] Add advice about scan-path in cgitrc.5.txt plenz
2011-03-10 17:33   ` hjemli
2011-03-10 17:22 ` [PATCH 1/5] guess default branch from HEAD hjemli
2011-03-16 10:53   ` plenz
2011-03-26 10:08     ` hjemli
2011-03-30 16:00       ` [PATCH v2] " plenz
2011-04-07  9:44         ` hjemli
2011-04-07 10:49           ` plenz
2011-04-07 10:59             ` [PATCH] " plenz
2011-06-10  6:42               ` jugg
2011-06-13 10:16                 ` larsh
2011-06-13 10:16                   ` hjemli
2011-06-16 14:59                     ` plenz
2011-06-20 19:25                       ` hjemli
2011-07-09  8:09                         ` jugg
2011-07-13 15:10                           ` plenz
2011-07-19  7:08                             ` larsh
2011-07-19  9:40                             ` jugg
2011-07-19  6:30                           ` larsh
2011-07-19  9:35                             ` jugg
2011-07-19  9:56                               ` larsh
2011-07-19 10:13                                 ` jugg [this message]
2011-07-21 10:34                                   ` larsh
2011-04-07 11:05             ` [PATCH v2] " hjemli
2011-06-09  4:40               ` jugg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20110719T120142-766@post.gmane.org \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).