From mboxrd@z Thu Jan 1 00:00:00 1970 From: jugg at hotmail.com (chris) Date: Tue, 19 Jul 2011 10:13:54 +0000 (UTC) Subject: [PATCH] guess default branch from HEAD References: <20110407104958.GB1004@plenz.com> <1302173964-12520-1-git-send-email-plenz@cis.fu-berlin.de> <20110613101621.GA29265@hjemli.net> <20110616145921.GA5875@plenz.com> <20110719063058.GA7524@hjemli.net> <20110719095607.GC16136@hjemli.net> Message-ID: writes: > On Tue, Jul 19, 2011 at 09:35:42AM +0000, chris wrote: > > Should guess_defbranch() be called here instead of hard-coding "master"? > > I don't think so, due to performance concerns (as explained earlier in this > thread). It's a compromise, favoring performance over correctness. Well, it sounds like premature optimization to me. I wonder how much performance impact that would really have, and if cgit's caching support doesn't negate any potential issue on busy servers anyway. I would expect correctness in user experience first. If correctness is shown to impact performance, I would expect solutions/compromises in those specific cases as needed. Of course I'm free to patch it to my liking obviously. This is just some user feedback for you. Thanks! chris