List for cgit developers and users
 help / color / mirror / Atom feed
From: mathstuf at gmail.com (Ben Boeckel)
Subject: [PATCH 0/3] Fix some issues found by Coverity
Date: Wed, 3 Feb 2016 04:46:44 +0000 (UTC)	[thread overview]
Message-ID: <n8s0nk$15k$1@ger.gmane.org> (raw)
In-Reply-To: <20160117202535.GR14056@serenity.lan>

On Sun, 17 Jan, 2016 at 20:25:36 GMT, John Keeping wrote:
> We're using "util" as a counter here, not a pointer.  But it's declared
> as "void*" so Coverity doesn't like this.
>
> We could try adding in some casts to uintptr_t but that's pretty
> hideous.  Otherwise we need to allocate an unsigned int for the "util"
> field or just ignore Coverity.

Incrementing a void* is undefined behavior (what is the step size?).

    https://stackoverflow.com/questions/6449935/increment-void-pointer-by-one-byte-by-two

--Ben



  reply	other threads:[~2016-02-03  4:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-16 11:03 john
2016-01-16 11:03 ` [PATCH 1/3] ui-log: handle parse_commit() errors john
2016-01-16 11:03 ` [PATCH 2/3] cache: use size_t for string lengths john
2016-01-16 11:03 ` [PATCH 3/3] cache: don't check for match with no key john
2016-01-17 16:04 ` [PATCH 0/3] Fix some issues found by Coverity Jason
2016-01-17 16:19   ` Jason
2016-01-17 20:25     ` john
2016-02-03  4:46       ` mathstuf [this message]
2016-02-08 13:35         ` Jason
2016-02-08 14:16           ` john
2016-02-08 14:33             ` Jason
2016-02-08 16:31               ` john
2016-02-08 17:26                 ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='n8s0nk$15k$1@ger.gmane.org' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).