Gnus development mailing list
 help / color / mirror / Atom feed
From: "Kai Großjohann" <kai.grossjohann@gmx.net>
Cc: ding@gnus.org, Kai.Grossjohann@cs.uni-dortmund.de
Subject: Re: [PATCH] byte-compiler warning suppression in nnir.el
Date: Sat, 25 Oct 2003 16:22:26 +0200 (MEST)	[thread overview]
Message-ID: <11268.1067091746@www59.gmx.net> (raw)
In-Reply-To: <microsoft-free.874qxy8g16.fsf@eicq.dnsalias.org>

(Braindead quoting because of limitations of my webmail thing.)

The idea behind the following patch is good, but what if the function is
already defined?  How about doing (unless (fboundp 'read-kbd-macro) (autoload
...))?  This could then be inside or outside of the eval-when-compile...

Hm.  But then, maybe during byte-compile the function is never defined?  Hm.
 No, if people do M-x byte-compile-file RET, then most probably
read-kbd-macro is defined already.

Index: contrib/nnir.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/contrib/nnir.el,v
retrieving revision 1.2
diff -u -u -r1.2 nnir.el
--- contrib/nnir.el    30 Sep 2003 21:30:34 -0000    1.2
+++ contrib/nnir.el    24 Oct 2003 21:43:38 -0000
@@ -308,7 +308,8 @@
 (eval-and-compile
   (require 'gnus-util))
 (eval-when-compile
-  (require 'nnimap))
+  (require 'nnimap)
+  (autoload 'read-kbd-macro "edmacro" nil t))
 
 (nnoo-declare nnir)
 (nnoo-define-basics nnir)


-- 
I like BOTH kinds of music!

NEU FÜR ALLE - GMX MediaCenter - für Fotos, Musik, Dateien...
Fotoalbum, File Sharing, MMS, Multimedia-Gruß, GMX FotoService

Jetzt kostenlos anmelden unter http://www.gmx.net

+++ GMX - die erste Adresse für Mail, Message, More! +++




  reply	other threads:[~2003-10-25 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-24 21:47 Steve Youngs
2003-10-25 14:22 ` Kai Großjohann [this message]
2003-10-25 17:59   ` Steve Youngs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11268.1067091746@www59.gmx.net \
    --to=kai.grossjohann@gmx.net \
    --cc=Kai.Grossjohann@cs.uni-dortmund.de \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).