[PATCH] byte-compiler warning suppression in nnir.el

[PATCH] byte-compiler warning suppression in nnir.el

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

Hi Kai!

This fixes a pesky "Undefined function" warning in nnir.el.

NOTE: This patch has been committed.


Gnus patch:
ChangeLog files diff command: cvs -q diff -U 0
Files affected:               contrib/ChangeLog
Source files diff command:    cvs -q diff -uN
Files affected:               contrib/nnir.el

Index: contrib/ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/contrib/ChangeLog,v
retrieving revision 1.82
diff -u -U0 -r1.82 ChangeLog
--- contrib/ChangeLog	30 Sep 2003 21:30:34 -0000	1.82
+++ contrib/ChangeLog	24 Oct 2003 21:43:42 -0000
@@ -0,0 +1,4 @@
+2003-10-24  Steve Youngs  <sryoungs@bigpond.net.au>
+
+	* nnir.el: Autoload `read-kbd-macro' at compile time.
+
Index: contrib/nnir.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/contrib/nnir.el,v
retrieving revision 1.2
diff -u -u -r1.2 nnir.el
--- contrib/nnir.el	30 Sep 2003 21:30:34 -0000	1.2
+++ contrib/nnir.el	24 Oct 2003 21:43:38 -0000
@@ -308,7 +308,8 @@
 (eval-and-compile
   (require 'gnus-util))
 (eval-when-compile
-  (require 'nnimap))
+  (require 'nnimap)
+  (autoload 'read-kbd-macro "edmacro" nil t))
 
 (nnoo-declare nnir)
 (nnoo-define-basics nnir)

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|              Ashes to ashes, dust to dust.               |
|      The proof of the pudding, is under the crust.       |
|------------------------------<sryoungs@bigpond.net.au>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

Re: [PATCH] byte-compiler warning suppression in nnir.el

[Kai Großjohann]

(Braindead quoting because of limitations of my webmail thing.)

The idea behind the following patch is good, but what if the function is
already defined?  How about doing (unless (fboundp 'read-kbd-macro) (autoload
...))?  This could then be inside or outside of the eval-when-compile...

Hm.  But then, maybe during byte-compile the function is never defined?  Hm.
 No, if people do M-x byte-compile-file RET, then most probably
read-kbd-macro is defined already.

Index: contrib/nnir.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/contrib/nnir.el,v
retrieving revision 1.2
diff -u -u -r1.2 nnir.el
--- contrib/nnir.el    30 Sep 2003 21:30:34 -0000    1.2
+++ contrib/nnir.el    24 Oct 2003 21:43:38 -0000
@@ -308,7 +308,8 @@
 (eval-and-compile
   (require 'gnus-util))
 (eval-when-compile
-  (require 'nnimap))
+  (require 'nnimap)
+  (autoload 'read-kbd-macro "edmacro" nil t))
 
 (nnoo-declare nnir)
 (nnoo-define-basics nnir)


-- 
I like BOTH kinds of music!

NEU FÜR ALLE - GMX MediaCenter - für Fotos, Musik, Dateien...
Fotoalbum, File Sharing, MMS, Multimedia-Gruß, GMX FotoService

Jetzt kostenlos anmelden unter http://www.gmx.net

+++ GMX - die erste Adresse für Mail, Message, More! +++

Re: [PATCH] byte-compiler warning suppression in nnir.el

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

|--==> "KG" == Kai Großjohann <kai.grossjohann@gmx.net> writes:

  KG> The idea behind the following patch is good, but what if the
  KG> function is already defined?

It won't matter, `autoload' will simply return `nil' in that case.

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|              Ashes to ashes, dust to dust.               |
|      The proof of the pudding, is under the crust.       |
|------------------------------<sryoungs@bigpond.net.au>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]