Gnus development mailing list
 help / color / mirror / Atom feed
From: Florian Ragwitz <rafl@debian.org>
To: ding@gnus.org
Cc: Florian Ragwitz <rafl@debian.org>
Subject: [PATCH] Decode URL entities to avoid broken links
Date: Mon, 27 Sep 2010 01:33:50 +0200	[thread overview]
Message-ID: <1285544030-23102-1-git-send-email-rafl@debian.org> (raw)

<a href="http://example.com/foo?moo=kooh&affe=tiger">example</a>
shouldn't point to http://example.com/foo?moo=kooh&amp;affe=tiger
---
 lisp/ChangeLog    |    5 +++++
 lisp/gnus-html.el |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 92cdd90..864c570 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2010-09-26  Florian Ragwitz  <rafl@debian.org>
+
+	* gnus-html.el (gnus-html-wash-tags): Decode URL entities to avoid
+	handing broken links to browse-url.
+
 2010-09-26  Lars Magne Ingebrigtsen  <larsi@gnus.org>
 
 	* nndoc.el (nndoc-request-list): Return success always.
diff --git a/lisp/gnus-html.el b/lisp/gnus-html.el
index 587c28e..4bac528 100644
--- a/lisp/gnus-html.el
+++ b/lisp/gnus-html.el
@@ -286,7 +286,7 @@ Use ALT-TEXT for the image string."
 	  (setq url (match-string 1 parameters))
           (gnus-message 8 "gnus-html-wash-tags: fetching link URL %s" url)
 	  (gnus-article-add-button start end
-				   'browse-url url
+				   'browse-url (mm-url-decode-entities-string url)
 				   url)
 	  (let ((overlay (gnus-make-overlay start end)))
 	    (gnus-overlay-put overlay 'evaporate t)
-- 
1.7.1




             reply	other threads:[~2010-09-26 23:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-26 23:33 Florian Ragwitz [this message]
2010-09-27 10:37 ` Julien Danjou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285544030-23102-1-git-send-email-rafl@debian.org \
    --to=rafl@debian.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).