Gnus development mailing list
 help / color / mirror / Atom feed
From: Jochen Hein <jochen@jochen.org>
To: ding@gnus.org
Cc: larsi@gnus.org, Jochen Hein <jochen@jochen.org>
Subject: [PATCH 1/4] open-gssapi-stream: remove parameter user
Date: Sun, 14 Feb 2016 17:07:06 +0100	[thread overview]
Message-ID: <1455466029-12376-2-git-send-email-jochen@jochen.org> (raw)
In-Reply-To: <1455466029-12376-1-git-send-email-jochen@jochen.org>

Remove the parameter user from open-gssapi-stream, the processing of
that parameter and '?l' from the gssapi-program template.

Now we can call open-gssapi-stream from open-network-stream.

	* lisp/gnus/gssapi.el (gssapi-program): remove username in
	command templates.
	(open-gssapi-stream): remove the parameter user, so we can
	call open-gssapi-stream from open-network-stream.
---
 lisp/gnus/gssapi.el | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/lisp/gnus/gssapi.el b/lisp/gnus/gssapi.el
index 1f72805..08b2ec3 100644
--- a/lisp/gnus/gssapi.el
+++ b/lisp/gnus/gssapi.el
@@ -29,9 +29,8 @@
 
 (defcustom gssapi-program (list
 			   (concat "gsasl %s %p "
-				   "--mechanism GSSAPI "
-				   "--authentication-id %l")
-			   "imtest -m gssapi -u %l -p %p %s")
+				   "--mechanism GSSAPI ")
+			   "imtest -m gssapi -p %p %s")
   "List of strings containing commands for GSSAPI (krb5) authentication.
 %s is replaced with server hostname, %p with port to connect to,
 and %l with the user name.  The program should accept commands on
@@ -41,7 +40,7 @@ gssapi-program
   :group 'network
   :type '(repeat string))
 
-(defun open-gssapi-stream (name buffer server port user)
+(defun open-gssapi-stream (name buffer server port)
   (let ((cmds gssapi-program)
 	cmd done)
     (with-current-buffer buffer
@@ -57,8 +56,7 @@ open-gssapi-stream
 			  cmd
 			  (format-spec-make
 			   ?s server
-			   ?p (number-to-string port)
-			   ?l user))))
+			   ?p (number-to-string port)))))
 	       response)
 	  (when process
 	    (while (and (memq (process-status process) '(open run))
@@ -92,7 +90,6 @@ open-gssapi-stream
 				  (setq response (match-string 1)))))
 	      (accept-process-output process 1)
 	      (sit-for 1))
-	    (erase-buffer)
 	    (message "GSSAPI connection: %s" (or response "failed"))
 	    (if (and response (let ((case-fold-search nil))
 				(not (string-match "failed" response))))
-- 
2.1.4




  reply	other threads:[~2016-02-14 16:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-14 16:07 allow GSSAPI for imap access Jochen Hein
2016-02-14 16:07 ` Jochen Hein [this message]
2016-02-14 16:07 ` [PATCH 2/4] network-stream: allow type gssapi Jochen Hein
2016-02-14 16:07 ` [PATCH 3/4] nnimap: handle imap connections with type 'gssapi Jochen Hein
2016-02-14 16:07 ` [PATCH 4/4] update nnimap documentation for gssapi connections Jochen Hein
2016-02-15  7:59 ` allow GSSAPI for imap access Lars Ingebrigtsen
2016-02-15 14:35   ` Adam Sjøgren
2016-02-15 16:39     ` Jochen Hein
2016-02-15 17:29       ` Adam Sjøgren
2016-02-15 18:31         ` Jochen Hein
2016-02-15 18:56           ` Adam Sjøgren
2016-02-15 19:58             ` Jochen Hein
2016-02-22  7:27           ` Adam Sjøgren
2016-02-22 18:41             ` Jochen Hein
2016-02-23 12:52               ` Adam Sjøgren
2016-02-15 14:38   ` Hein, Jochen
2016-02-15 14:46     ` Lars Ingebrigtsen
2016-02-16  5:57 ` Lars Ingebrigtsen
2016-02-16  9:21   ` Hein, Jochen
2016-02-21  3:10     ` Lars Ingebrigtsen
2016-03-20 19:11       ` Jochen Hein/Jochen Kellner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455466029-12376-2-git-send-email-jochen@jochen.org \
    --to=jochen@jochen.org \
    --cc=ding@gnus.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).