From: Glenn Morris <rgm@gnu.org>
To: Gnus <ding@gnus.org>
Subject: Move gnus-article-mode-line-format-alist to gnus-sum.el
Date: Mon, 3 Mar 2008 23:02:33 -0500 [thread overview]
Message-ID: <18380.51673.874667.613180@fencepost.gnu.org> (raw)
[please cc me in any replies; I'm not subscribed]
Any objection to my moving the definition of
gnus-article-mode-line-format-alist from gnus-art to gnu-sum? This
simplifies the compilation of gnus-sum, since it no longer has to load
its own uncompiled source file part way through.
Patch against Emacs CVS trunk versions:
*** gnus-art.el 29 Feb 2008 04:03:49 -0000 1.155
--- gnus-art.el 4 Mar 2008 03:55:14 -0000
***************
*** 1700,1710 ****
(defvar gnus-save-article-buffer nil)
- (defvar gnus-article-mode-line-format-alist
- (nconc '((?w (gnus-article-wash-status) ?s)
- (?m (gnus-article-mime-part-status) ?s))
- gnus-summary-mode-line-format-alist))
-
(defvar gnus-number-of-articles-to-be-saved nil)
(defvar gnus-inhibit-hiding nil)
--- 1700,1705 ----
*** gnus-sum.el 4 Mar 2008 03:52:10 -0000 1.120
--- gnus-sum.el 4 Mar 2008 03:53:28 -0000
***************
*** 1372,1377 ****
--- 1372,1383 ----
(?E gnus-newsgroup-expunged-tally ?d)
(?s (gnus-current-score-file-nondirectory) ?s)))
+ ;; This is here rather than in gnus-art for compilation reasons.
+ (defvar gnus-article-mode-line-format-alist
+ (nconc '((?w (gnus-article-wash-status) ?s)
+ (?m (gnus-article-mime-part-status) ?s))
+ gnus-summary-mode-line-format-alist))
+
(defvar gnus-last-search-regexp nil
"Default regexp for article search command.")
***************
*** 1563,1583 ****
\"^From:\\\\|^Newsgroups:\\\\|^Subject:\\\\|^Date:\\\\|^To:\")))
")
- ;; Byte-compiler warning. Specifically, this is responsible for:
- ;; "Warning: the following functions might not be defined at runtime:
- ;; gnus-build-sparse-threads, gnus-dead-summary-mode, gnus-summary-mark-below".
(eval-when-compile
;; Bind features so that require will believe that gnus-sum has
;; already been loaded (avoids infinite recursion)
(let ((features (cons 'gnus-sum features)))
- ;; Several of the declarations in gnus-sum are needed to load the
- ;; following files. Right now, these definitions have been
- ;; compiled but not defined (evaluated). We could either do a
- ;; eval-and-compile about all of the declarations or evaluate the
- ;; source file.
- (if (boundp 'gnus-newsgroup-variables)
- nil
- (load "gnus-sum.el" t t t))
(require 'gnus-art)))
;; MIME stuff.
--- 1569,1578 ----
next reply other threads:[~2008-03-04 4:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 4:02 Glenn Morris [this message]
2008-03-04 22:11 ` Reiner Steib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18380.51673.874667.613180@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).