From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66425 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.gnus.general Subject: Move gnus-article-mode-line-format-alist to gnus-sum.el Date: Mon, 3 Mar 2008 23:02:33 -0500 Message-ID: <18380.51673.874667.613180@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1204603442 16678 80.91.229.12 (4 Mar 2008 04:04:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Mar 2008 04:04:02 +0000 (UTC) To: Gnus Original-X-From: ding-owner+M14916@lists.math.uh.edu Tue Mar 04 05:04:28 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1JWOO9-0001iJ-Sz for ding-account@gmane.org; Tue, 04 Mar 2008 05:04:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1JWOMW-000090-LX; Mon, 03 Mar 2008 22:02:44 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1JWOMV-00008p-CH for ding@lists.math.uh.edu; Mon, 03 Mar 2008 22:02:43 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1JWOMP-0008AC-2g for ding@lists.math.uh.edu; Mon, 03 Mar 2008 22:02:43 -0600 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1JWOMU-0000fJ-00 for ; Tue, 04 Mar 2008 05:02:42 +0100 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1JWOML-0007l0-VG; Mon, 03 Mar 2008 23:02:33 -0500 Mail-Followup-To: rgm@gnu.org, ding@gnus.org X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: (~}Q1t:@P-Bi;~6(eCdC4=R:xJ*UVc6+q_BL<%Fpe[O4erbvL-YECch*o>vFIX8b'SHUCT X-Spam-Score: -2.5 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66425 Archived-At: [please cc me in any replies; I'm not subscribed] Any objection to my moving the definition of gnus-article-mode-line-format-alist from gnus-art to gnu-sum? This simplifies the compilation of gnus-sum, since it no longer has to load its own uncompiled source file part way through. Patch against Emacs CVS trunk versions: *** gnus-art.el 29 Feb 2008 04:03:49 -0000 1.155 --- gnus-art.el 4 Mar 2008 03:55:14 -0000 *************** *** 1700,1710 **** (defvar gnus-save-article-buffer nil) - (defvar gnus-article-mode-line-format-alist - (nconc '((?w (gnus-article-wash-status) ?s) - (?m (gnus-article-mime-part-status) ?s)) - gnus-summary-mode-line-format-alist)) - (defvar gnus-number-of-articles-to-be-saved nil) (defvar gnus-inhibit-hiding nil) --- 1700,1705 ---- *** gnus-sum.el 4 Mar 2008 03:52:10 -0000 1.120 --- gnus-sum.el 4 Mar 2008 03:53:28 -0000 *************** *** 1372,1377 **** --- 1372,1383 ---- (?E gnus-newsgroup-expunged-tally ?d) (?s (gnus-current-score-file-nondirectory) ?s))) + ;; This is here rather than in gnus-art for compilation reasons. + (defvar gnus-article-mode-line-format-alist + (nconc '((?w (gnus-article-wash-status) ?s) + (?m (gnus-article-mime-part-status) ?s)) + gnus-summary-mode-line-format-alist)) + (defvar gnus-last-search-regexp nil "Default regexp for article search command.") *************** *** 1563,1583 **** \"^From:\\\\|^Newsgroups:\\\\|^Subject:\\\\|^Date:\\\\|^To:\"))) ") - ;; Byte-compiler warning. Specifically, this is responsible for: - ;; "Warning: the following functions might not be defined at runtime: - ;; gnus-build-sparse-threads, gnus-dead-summary-mode, gnus-summary-mark-below". (eval-when-compile ;; Bind features so that require will believe that gnus-sum has ;; already been loaded (avoids infinite recursion) (let ((features (cons 'gnus-sum features))) - ;; Several of the declarations in gnus-sum are needed to load the - ;; following files. Right now, these definitions have been - ;; compiled but not defined (evaluated). We could either do a - ;; eval-and-compile about all of the declarations or evaluate the - ;; source file. - (if (boundp 'gnus-newsgroup-variables) - nil - (load "gnus-sum.el" t t t)) (require 'gnus-art))) ;; MIME stuff. --- 1569,1578 ----