SCORING bug again (was: September Gnus 0.41 is released)

[boubaker@cenatls.cena.dgac.fr]

 Lars, 
 
 I saw you modified gnus-score-headers but apparently that's not enought
... sorry, the condition (gnus-score.el line 1044):

      (when (and gnus-summary-default-score
		 scores
		 (> (length gnus-newsgroup-headers)
		    (length gnus-newsgroup-scored)))

is sometimes false and only a rescore summary (gnus-summary-rescore) can give
the correct scoring.

 don't give up you'll succeed :-) (it seems that the fault is from the > test,
maybe it should be >= see the included trace below)
 
 ---Trace----
 
 I put a message trace like that:
    ;; Do the scoring.
    (while news
      (setq scores news
	    news nil)
      (message "In gnus-score-headers!!: \n\tscores: %s \n\tgnus-newsgroup-headers: %s \n\tgnus-newsgroup-scored: %s"
               scores gnus-newsgroup-headers gnus-newsgroup-scored)
      (when (and gnus-summary-default-score
		 scores
		 (> (length gnus-newsgroup-headers)
		    (length gnus-newsgroup-scored)))

 And in a newsgoup where scoring failed I've got:

In gnus-score-headers!!: 
	scores: (((read-only t) (touched nil) (subject (!! -10 nil s) (** -10 nil s) (please read -10 nil s) (^\([Rr][Ee]: +\)?[^a-z
]+$ -5 nil R) ($$ -10 nil s) (easy money -1000 nil s) (^\(re:\)? *[(<]?\(none\|no subject\( given!?\)?\)?[>)]? *$ -10 nil r) (ann?ou?nc\(e\|ing\) 10 nil r) (\(un\)?sub?scribe -1001 nil r) (your mail -1001 nil s) (\(m\(icro\)?[s$]\(oft\|lo\(th?\|w\)\)?-?\)?wind?\(ows\|aube\|oze\)?[-. ]*\(["']?95\|NT\|3[.]1\|32\) -1001 nil r) (\b\(os/?2\|aix\|ultrix\|vms\|osf/?1\|amiga\|atari\|hp-?ux\|solaris\|rs6000\)\b -100 nil r) (Fortran\|f77 -100 nil r) (\(for\|4\)[- ]*sale -100 nil r) (^F/?S:?  -100 nil r) (\[[^a-z0-9 	
][^a-z0-9 	
]\] 100 nil r)) (from (.aol.com -10 nil s) (.msn.com -10 nil s) (anon.penet.fi -10 nil s) (.sgi.com 10 nil s) (.cenatls.cena.dgac.fr 1000 nil s) (.cena.dgac.fr 100 nil s) (.dgac.fr 10 nil s)) (followup (boubaker 1000 nil s)) (lines (1 -10 nil <=)) (mark -100) (expunge -1000)) ((touched nil) (subject (ppp\|slip -10 nil r) (indy 10 nil s) (impact 10 nil s))) ((touched nil) (from (Michael/Miguel Sanchez <miguel@sgi.com> 2 728711 s) (davea@quasar.engr.sgi.com (David B.Anderson) 1 728710 s) (fehrin@math.TU-Berlin.DE (Franz Fehringer) 1 728710 s) (Heinz Mungenast <mungo@stk.co.at> 1 728709 s) (shankar@mti.sgi.com (Shankar Unni) 1 728710 s) (Albrecht Melan <melan@isd.uni-stuttgart.de> 1 728708 s) ("R.M.Harris" <R.M.Harris@msm.cam.ac.uk> 2 728705 s) (Ken Spickler <ken@varitel-eds.com> 1 728705 s) (Kirk Erickson <kirke@sgi.com> 1 728704 s)) (subject (FYI: PGP 2.6.3 precompiled for SGI. 5 728711 f) (FYI: Secure Shell for SGI. 5 728711 f) (AVI Support Conversion on SGI? -100 728711 f) (
 SGI/Novell Integration -100 728710 f) (dmrecord problem -200 728710 f) (teTeX with tardist? -300 728710 f) (nm bug? 5 728710 f) (nm bug? 5 728710 e) (Softwindows 2 on Indy -300 728710 f) (unsubscribe -500 728709 f) (Event recorder 5 728709 f) (64-bit: speed gain? -200 728709 f) (SGI pointer Frequently Asked Questions -100 728709 f) (Applications of IRIX 5.3 run under IRIX 6.2? -1200 728710 f) (MediaMail problem -200 728708 f) (Help Reading SGI Binary Data in a PC -100 728708 f) (integrated video by integrated research -100 728708 f) (Java on SGI 10 728709 f) (jot with group rights -200 728709 f) (e-mail Amazon Paint -1200 728711 f) (Motif 2.0 -100 728708 f) (moviemaker, makemovie problem -200 728708 f) (soundplayer interaction with Netscape -1200 728710 f) (Anyone has Star Trek audio effects on SGI? -100 728708 f) (Where to get vof file for HighImace to support VGA? -100 728708 f) (Flexlm and hostname-HELP -900 728709 f) (Solvers for R8000 -200 728708 f) (SGI driver for Far
 go Pictura 310 color printer -100 728705 f) (SyBASE sybinit problems 



under IRIX 5.3 -- Please Help -200 728705 f) (jot's Options/Filter command annoying behaviour -700 728709 f) (Elm with MIME attachments. -200 728708 f) (Downloading Macintosh software with Netscape 2.0 -1200 728708 f) (REQ: a timed IndyCam grabber 15 728705 f) (test -100 728704 e) (Plexing on 5.3 w/XFS -10 728704 f) (looking for shar utility -200 728704 f) (Env. Variables in CVD Debugger -700 728704 f) (Configure disk to work with XFS -200 728704 f) (Installing Netscape2.0 -1200 728705 f) (Z-mail and priorities -200 728704 f) (Power Challenge question -200 728705 f) (LaTeX with WYSISWYG? -100 728704 f) (64bit? -1900 728710 f) (64bit? -100 728704 e) (xdvi under IRIX 5.3 & ghostview -100 728704 f) (Motif for SGI -210 728709 f) (Parallel Make dependency problem -200 728704 f) (Netsite Server Admin Stuff -700 728711 f) (netscape_2.0 -595 728704 f) (memtovid source -90 728704 f) (wn web server/swn -200 728708 f) (Impressario: postscript problems -200 728708 f) (Best *graphical* FT
 P client? -995 728708 f) (gcc/libg++ on MIPS R8000 -900 728705 f) (REQUEST: POP3 Client IRIX v5.3 -1200 728705 f) (SGI and C++ -2695 728710 f) (REQ: .WAV and .MOV player for SGI Indigo -1300 728708 f))) ((touched nil) (subject (open[- ]*gl 10 nil r))) ((touched nil) (subject (\btest\(ing\)?\b -100 nil r))) ((touched nil) (from (\.fr[^a-zA-Z0-9
]+ 10 nil r))) ((touched nil) (subject (FAQ[^?
]*$ 100 nil r)) (xref (^xref: \S-+ \S-+ \S-+ \S-+ -1 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ -2 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ -4 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ -8 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ -16 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ -32 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ -64 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ -128 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ -256 nil r) (^xref: \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ \S-+ -512 nil r))) ((touched nil) (subject (emacs 100 nil s)))) 
	gnus-newsgroup-headers: ([10541 Mustek Scanner & Irix 5.3 brian@weirich530.geomorphology.uiowa.edu (Brian Aker) 22 Feb 1996 16:35:04 GMT <4gi5vo$18dg@flood.weeg.uiowa.edu>  1042 11 ] [10542 CUseeme porter@firefox.rutgers.edu (Adam Porter) 22 Feb 1996 12:15:30 -0500 <4gi8bi$rvv@firefox.rutgers.edu>  813 8 ] [10543 Re: soundplayer interaction with Netscape porter@firefox.rutgers.edu (Adam Porter) 22 Feb 1996 12:19:28 -0500 <4gi8j0$s8v@firefox.rutgers.edu> <4eu3iu$3jc@caip.rutgers.edu> 1527 25 ] [10544 Re: FYI: PGP 2.6.3 precompiled for SGI. dellwo@spruce.chem.upenn.edu (Martin J. Dellwo) 22 Feb 1996 16:49:28 GMT <4gi6qo$5nh@netnews.upenn.edu> <4ft8lv$hpo@dcdmjw.fnal.gov> <312BCA21.59E2@sgi.com> 1213 16 ] [10546 Help!! Plextor 6x (M2934S) Cd-Rom Drive Gavenraj Sodhi <sodhgav@charlie.acc.iit.edu> Thu, 22 Feb 1996 19:40:36 -0600 <312D1B14.2D7C@charlie.acc.iit.edu>  1050 14 ] [10547 HELP!!!!   NEED getting my Plextor 6x CD-ROM drive to work with my Indy R4600PC Gavenraj Sodhi <sod
 hgav@charlie.acc.iit.edu> Thu, 22 Feb 1996 19:35:50 -0600 <312D19F6.608C@charlie.acc.iit.edu>  1057 14 ]) 
	gnus-newsgroup-scored: ((10539 . -200) (10540 . -200) (10536 . -200) (10533 . -100) (10532 . -100) (10531 . -90))

       
 You can see that gnus-newsgroup-headers is = gnus-newsgroup-scored.
 If I then rescore the group I've got:

In gnus-score-headers!!: 
[score deleted]
	gnus-newsgroup-headers: ([10541 Mustek Scanner & Irix 5.3 brian@weirich530.geomorphology.uiowa.edu (Brian Aker) 22 Feb 1996 16:35:04 GMT <4gi5vo$18dg@flood.weeg.uiowa.edu>  1042 11 ] [10542 CUseeme porter@firefox.rutgers.edu (Adam Porter) 22 Feb 1996 12:15:30 -0500 <4gi8bi$rvv@firefox.rutgers.edu>  813 8 ] [10543 Re: soundplayer interaction with Netscape porter@firefox.rutgers.edu (Adam Porter) 22 Feb 1996 12:19:28 -0500 <4gi8j0$s8v@firefox.rutgers.edu> <4eu3iu$3jc@caip.rutgers.edu> 1527 25 ] [10544 Re: FYI: PGP 2.6.3 precompiled for SGI. dellwo@spruce.chem.upenn.edu (Martin J. Dellwo) 22 Feb 1996 16:49:28 GMT <4gi6qo$5nh@netnews.upenn.edu> <4ft8lv$hpo@dcdmjw.fnal.gov> <312BCA21.59E2@sgi.com> 1213 16 ] [10546 Help!! Plextor 6x (M2934S) Cd-Rom Drive Gavenraj Sodhi <sodhgav@charlie.acc.iit.edu> Thu, 22 Feb 1996 19:40:36 -0600 <312D1B14.2D7C@charlie.acc.iit.edu>  1050 14 ] [10547 HELP!!!!   NEED getting my Plextor 6x CD-ROM drive to work with my Indy R4600PC Gavenraj Sodhi <sod
 hgav@charlie.acc.iit.edu> Thu, 22 Feb 1996 19:35:50 -0600 <312D19F6.608C@charlie.acc.iit.edu>  1057 14 ]) 
	gnus-newsgroup-scored: nil
Scoring...
Scoring...done

 And then a second call to gnus-score-headers as:
In gnus-score-headers!!: 
	scores: (((references))) 
	gnus-newsgroup-headers: ([10541 Mustek Scanner & Irix 5.3 brian@weirich530.geomorphology.uiowa.edu (Brian Aker) 22 Feb 1996 16:35:04 GMT <4gi5vo$18dg@flood.weeg.uiowa.edu>  1042 11 ] [10542 CUseeme porter@firefox.rutgers.edu (Adam Porter) 22 Feb 1996 12:15:30 -0500 <4gi8bi$rvv@firefox.rutgers.edu>  813 8 ] [10543 Re: soundplayer interaction with Netscape porter@firefox.rutgers.edu (Adam Porter) 22 Feb 1996 12:19:28 -0500 <4gi8j0$s8v@firefox.rutgers.edu> <4eu3iu$3jc@caip.rutgers.edu> 1527 25 ] [10544 Re: FYI: PGP 2.6.3 precompiled for SGI. dellwo@spruce.chem.upenn.edu (Martin J. Dellwo) 22 Feb 1996 16:49:28 GMT <4gi6qo$5nh@netnews.upenn.edu> <4ft8lv$hpo@dcdmjw.fnal.gov> <312BCA21.59E2@sgi.com> 1213 16 ] [10546 Help!! Plextor 6x (M2934S) Cd-Rom Drive Gavenraj Sodhi <sodhgav@charlie.acc.iit.edu> Thu, 22 Feb 1996 19:40:36 -0600 <312D1B14.2D7C@charlie.acc.iit.edu>  1050 14 ] [10547 HELP!!!!   NEED getting my Plextor 6x CD-ROM drive to work with my Indy R4600PC Gavenraj Sodhi <sod
 hgav@charlie.acc.iit.edu> Thu, 22 Feb 1996 19:35:50 -0600 <312D19F6.608C@charlie.acc.iit.edu>  1057 14 ]) 
	gnus-newsgroup-scored: ((10543 . -1200) (10544 . 5) (10546 . -10))
Scoring...
Scoring...done

 good luck
 
 - heddy -