Re: MIME attachments?

[Jan Vroonhof <vroonhof@math.ethz.ch>]

> > > You have to use insert-file-contents if you want to be able to attach files 
> > > through efs / ange-ftp / rcp / whatever.
> > 
> > That is a bug in insert-file-contents-literally, it really should be made
> > a file-handler method. Apperently FSF Emacs 20.4 already contains a a
>
> I don't think I quite understand how you would make
> insert-file-contents-literally work for EFS files and yet not let things
> like jka-compr and friends get at it.

Simply let jka-compr and friends not implement it, like this (note the 
absence of any patch to jka-comp.el). Only kai has get to work to do
this for rcp.el:

1999-06-15  Jan Vroonhof  <vroonhof@math.ethz.ch>

	* efs.el (efs-insert-file-contents-general): Generalized i-f-c
	function derived from old i-f-c function.
	(efs-insert-file-contents): Use it.
	(efs-insert-file-contents-literally): Use it.

	* files.el (insert-file-contents-literally): Use binary coding
	system (from Morioka san).
	(insert-file-contents-literally): Make file-name-handler method.

	

Index: lisp/files.el
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs-20/lisp/files.el,v
retrieving revision 1.31
diff -u -u -r1.31 files.el
--- files.el	1999/05/13 12:19:37	1.31
+++ files.el	1999/06/16 02:26:06
@@ -874,23 +874,31 @@
 (defun insert-file-contents-literally (filename &optional visit beg end replace)
   "Like `insert-file-contents', q.v., but only reads in the file.
 A buffer may be modified in several ways after reading into the buffer due
-to advanced Emacs features, such as file-name-handlers, format decoding,
-find-file-hooks, etc.
+to advanced Emacs features, such as format decoding, character code
+conversion,find-file-hooks, automatic uncompression, etc.
+
   This function ensures that none of these modifications will take place."
-  (let ((file-name-handler-alist nil)
-	(format-alist nil)
-	(after-insert-file-functions nil)
-	(find-buffer-file-type-function
-	 (if (fboundp 'find-buffer-file-type)
-	     (symbol-function 'find-buffer-file-type)
-	   nil)))
-    (unwind-protect
-	(progn
-	  (fset 'find-buffer-file-type (lambda (filename) t))
-	  (insert-file-contents filename visit beg end replace))
-      (if find-buffer-file-type-function
-	  (fset 'find-buffer-file-type find-buffer-file-type-function)
-	(fmakunbound 'find-buffer-file-type)))))
+  (let ((wrap-func (find-file-name-handler filename
+					   'insert-file-contents-literally)))
+    (if wrap-func 
+	(funcall wrap-func 'insert-file-contents-literally filename
+		 visit beg end replace)
+      (let ((file-name-handler-alist nil)
+	    (format-alist nil)
+	    (after-insert-file-functions nil)
+	    (coding-system-for-read 'binary)
+	    (coding-system-for-read 'binary)
+	    (find-buffer-file-type-function
+	     (if (fboundp 'find-buffer-file-type)
+		 (symbol-function 'find-buffer-file-type)
+	       nil)))
+	(unwind-protect
+	    (progn
+	      (fset 'find-buffer-file-type (lambda (filename) t))
+	      (insert-file-contents filename visit beg end replace))
+	  (if find-buffer-file-type-function
+	      (fset 'find-buffer-file-type find-buffer-file-type-function)
+	    (fmakunbound 'find-buffer-file-type)))))))
 
 (defun find-file-noselect (filename &optional nowarn rawfile)
   "Read file FILENAME into a buffer and return the buffer.


diff -u /scratch/vroonhof/cvs/xemacs-20/xemacs-packages/lisp/efs/efs.el~ /scratch/vroonhof/cvs/xemacs-20/xemacs-packages/lisp/efs/efs.el
--- /scratch/vroonhof/cvs/xemacs-20/xemacs-packages/lisp/efs/efs.el~	Tue Jun 15 20:45:13 1999
+++ /scratch/vroonhof/cvs/xemacs-20/xemacs-packages/lisp/efs/efs.el	Tue Jun 15 20:45:13 1999
@@ -88,6 +88,7 @@
 ;;; get-file-buffer
 ;;; insert-directory
 ;;; insert-file-contents
+;;; insert-file-contents-literally
 ;;; list-directory
 ;;; make-directory-internal
 ;;; rename-file
@@ -7011,10 +7012,21 @@
 	    (efs-set-buffer-mode))
 	(error "efs-write-region called for a local file")))))
 
-(defun efs-insert-file-contents (filename &optional visit &rest args)
+(defun efs-insert-file-contents (filename &rest args)
   ;; Inserts file contents for remote files.
   ;; The additional ARGS covers V19 BEG and END. Should also handle the
   ;; CODING-SYSTEM arg for mule. Hope the two don't trip over each other.
+  (apply 'efs-insert-file-contents-general 'insert-file-contents filename args))
+
+(defun efs-insert-file-contents-literally (filename &rest args)
+  ;; Inserts file contents for remote files.
+  ;; The additional ARGS covers V19 BEG and END. Should also handle the
+  ;; CODING-SYSTEM arg for mule. Hope the two don't trip over each other.
+  (apply 'efs-insert-file-contents-general 'insert-file-contents-literally
+	 filename args))
+
+(defun efs-insert-file-contents-general
+         (handled-func filename &optional visit &rest args)  
   (barf-if-buffer-read-only)
   (unwind-protect
       (let* ((filename (expand-file-name filename))
@@ -7055,7 +7067,7 @@
 		   (format "Retrieving %s" abbr)
 		   (efs-cont (result line cont-lines) (filename visit buffer
 								host-type
-								temp args)
+								temp handled-func args)
 		     (if result
 			 (signal 'ftp-error
 				 (list "Opening input file"
@@ -7073,7 +7085,7 @@
 				   (file-readable-p temp))
 			       
 			       (setq i-f-c-size
-				   (nth 1 (apply 'insert-file-contents
+				     (nth 1 (apply handled-func
 						 temp visit args)))
 			     (signal 'ftp-error
 				     (list
@@ -10449,6 +10461,7 @@
 
 ;; I/O
 (put 'insert-file-contents 'efs 'efs-insert-file-contents)
+(put 'insert-file-contents-literally 'efs 'efs-insert-file-contents-literally)
 (put 'write-region 'efs 'efs-write-region)
 (put 'directory-files 'efs 'efs-directory-files)
 (put 'list-directory 'efs 'efs-list-directory)