Gnus development mailing list
 help / color / mirror / Atom feed
From: ShengHuo ZHU <zsh@cs.rochester.edu>
Subject: Re: Problem with gnus-refer-article-method
Date: Tue, 24 Oct 2000 18:45:35 -0400	[thread overview]
Message-ID: <200010242245.e9OMjZW01832@zsh.2y.net> (raw)
In-Reply-To: <wkzojtzyyp.fsf@helium.eswe.dyndns.org>

Stefan Wiens <s.wi@gmx.net> writes:

> According to the documentation, the value of gnus-refer-article-method
> may be a single select method.
> 
> If I make (setq gnus-refer-article-method '(nntp "neon")) and try to
> read an old article not displayed in the summary buffer (e.g. by
> typing "^"), I get the error "Wrong type argument: listp, nntp".
> 
> This does not happen if gnus-refer-article-method is a symbol or a
> list of select methods (possibly containing a single method).
> 
> I tried to track this down, and found that the
> gnus-request-article-this-buffer function doesn't handle this case
> properly.
> 
> This is my first attempt to fix this:
> 
> --- gnus-art.el.orig	Sat Jul 01 13:10:42 2000
> +++ gnus-art.el	Sun Oct 22 22:16:24 2000
> @@ -3841,13 +3841,14 @@
>  	    (let ((gnus-override-method gnus-override-method)
>  		  (methods (and (stringp article) 
>  				gnus-refer-article-method))
>  		  result
>  		  (buffer-read-only nil))
>  	      (setq methods
> -		    (if (listp methods)
> +		    (if (and (listp methods)
> +			     (not (stringp (cadr methods))))
>  			methods
>  		      (list methods)))
>  	      (when (and (null gnus-override-method)
>  			 methods)
>  		(setq gnus-override-method (pop methods)))
>  	      (while (not result)
> 
> 
> A single nntp symbol gets "pop"ed into gnus-override-method. My fix
> was inspired by the gnus-refer-article-methods function, which
> performs a very similar work, but seems to do it correctly.

This fix doesn't work for '(current "archive").  Neither does the
gnus-refer-article-methods function.  I've installed another patch in
the CVS repository.

ShengHuo



  reply	other threads:[~2000-10-24 22:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-10-24 21:55 Stefan Wiens
2000-10-24 22:45 ` ShengHuo ZHU [this message]
2000-10-25 19:29   ` Stefan Wiens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200010242245.e9OMjZW01832@zsh.2y.net \
    --to=zsh@cs.rochester.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).