From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63271 Path: news.gmane.org!not-for-mail From: "Kevin Greiner" Newsgroups: gmane.emacs.gnus.semi.japanese,gmane.emacs.gnus.general Subject: Re: gnus-agent-read-local Date: Mon, 29 May 2006 09:01:39 -0500 Message-ID: <200605290901.AA34537584@mail.ev1.net> Reply-To: semi-gnus-ja@meadowy.org NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1148911194 753 80.91.229.2 (29 May 2006 13:59:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 29 May 2006 13:59:54 +0000 (UTC) Cc: Original-X-From: semi-gnus-ja-return-19034-gegsj-semi-gnus-ja-403=m.gmane.org@meadowy.org Mon May 29 15:59:51 2006 Return-path: Envelope-to: gegsj-semi-gnus-ja-403@gmane.org Original-Received: from farm.meadowy.org ([202.222.30.108]) by ciao.gmane.org with smtp (Exim 4.43) id 1FkiH9-0004Eb-6E for gegsj-semi-gnus-ja-403@gmane.org; Mon, 29 May 2006 15:59:20 +0200 Original-Received: (qmail 25425 invoked by uid 501); 29 May 2006 13:59:16 -0000 Mailing-List: contact semi-gnus-ja-help@meadowy.org; run by ezmlm Original-Sender: semi-gnus-ja-owner@meadowy.org X-ML-NAME: semi-gnus-ja Precedence: bulk Original-Received: (qmail 25419 invoked from network); 29 May 2006 13:59:16 -0000 X-SendingHost: 207.218.192.8 X-Sender: Original-To: X-Mailer: X-ML-COUNT: 19034 Xref: news.gmane.org gmane.emacs.gnus.semi.japanese:11630 gmane.emacs.gnus.general:63271 Archived-At: Binding obarray to my-obarray while calling read will avoid creating an initial global symbol. I've made the change and checked it in. Thanks for catching this... Kevin ---------- Original Message ---------------------------------- From: Katsumi Yamaoka Date: Mon, 29 May 2006 10:13:01 +0900 >Hi, > >YAGI Tatsuya reported that there is a bug in the >`gnus-agent-read-local' function. When it reads a >"~/News/agent/BACKEND/SERVER/agent.lib/local" file, many group >names listed in that file will be bound as global symbols. For >instance, if the file contains the following entry, > >gnu\.emacs\.gnus 1234 5678 > >the variable `gnu\.emacs\.gnus' will be bound globally and set >to the value `(1234 . 5678)'. As long as I understand, all such >symbols should be in the private obarray. Actually, the code >will do so if the first element of each entry is a string. >However, it doesn't, since all they are now just symbols. >Here's an extract of the `gnus-agent-read-local' function: > >--8<---------------cut here---------------start------------->8--- > (setq group (read cur) > min (read cur) > max (read cur)) > > (when (stringp group) > (setq group (intern group my-obarray))) > > ;; NOTE: The '+ 0' ensure that min and max are both numerics. > (set group (cons (+ 0 min) (+ 0 max))) >--8<---------------cut here---------------end--------------->8--- > >I think the middle part should be replaced with > >--8<---------------cut here---------------start------------->8--- > (if (stringp group) > (setq group (intern group my-obarray)) > (setq group (intern (symbol-name group) my- obarray))) >--8<---------------cut here---------------end--------------->8--- > >or simply with > >--8<---------------cut here---------------start------------->8--- > (setq group (intern (symbol-name group) my-obarray)) >--8<---------------cut here---------------end--------------->8--- > >However, I'm not sure the other functions work correctly >assuming those variables are the ones in the private obarray, >not global variables. Could anyone fix this properly? > >Regards, > > ________________________________________________________________ Sent via the EV1 webmail system at mail.ev1.net