From: Dan Nicolaescu <dann@ics.uci.edu>
To: Reiner Steib <Reiner.Steib@gmx.de>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Warning: `mapcar' called for effect; use `mapc' or `dolist'
Date: Mon, 22 Oct 2007 13:07:40 -0700 [thread overview]
Message-ID: <200710222007.l9MK7fRZ022140@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <v9fy0356iw.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Mon\, 22 Oct 2007 20\:49\:27 +0200")
Reiner Steib <reinersteib+gmane@imap.cc> writes:
> On Mon, Oct 22 2007, Katsumi Yamaoka wrote:
>
> >>>>>> Dan Nicolaescu wrote:
> >> The subject is about a new warning produced by the byte
> >> compiler. There's a lot of those for gnus.
> >> Assuming that all emacs versions that gnus wants to support have
> >> either mapc or dolist, can somebody please take care of these
> >> warnings?
> >
> >> Thanks
> >
> > With No Gnus v0.7 I did `cd lisp; make warn' and tried replacing
> > of `mapcar' with `mapc', `dolist', or `while' loops for a while,
> > and realized it's not easy and not safe. Ones who do it will
> > need to study what things using `mapcar' do in all cases. For
> > instance, `mapcar' used in `gnus-group-highlight-line' cannot be
> > replaced with `mapc' even if the compiler warns it.
>
> Could the byte-compiler be improved not to warn about such cases?
> Here's the relevant code:
>
> (defun gnus-group-highlight-line ()
> "Highlight the current line according to `gnus-group-highlight'."
> (let* ([...]
> (mailp (apply 'append
> (mapcar
> (lambda (x)
> (memq x (assoc (symbol-name
> (car (or method gnus-select-method)))
> gnus-valid-select-methods)))
> '(mail post-mail))))
> (level (or (gnus-info-level info) gnus-level-killed))
It seems that `mailp' is not used in that function. Adding a use for
it makes the warning go away...
next prev parent reply other threads:[~2007-10-22 20:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 6:43 Dan Nicolaescu
2007-10-22 12:13 ` Katsumi Yamaoka
2007-10-22 18:49 ` Reiner Steib
2007-10-22 20:07 ` Dan Nicolaescu [this message]
2007-10-22 20:55 ` Reiner Steib
2007-10-22 21:04 ` Dan Nicolaescu
2007-10-22 21:39 ` Glenn Morris
2007-10-23 1:01 ` Miles Bader
2007-10-23 10:39 ` Richard Stallman
2007-10-23 10:39 ` Richard Stallman
2007-10-27 10:46 ` Risky variables in Gnus (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib
2007-10-27 23:41 ` Richard Stallman
2007-10-28 0:02 ` Risky variables in Gnus Reiner Steib
2007-11-01 20:51 ` Reiner Steib
2007-10-27 10:46 ` Rewriting gnus-group-highlight-line (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib
2007-10-27 23:41 ` Richard Stallman
2007-10-28 0:05 ` Reiner Steib
2007-10-23 10:39 ` Warning: `mapcar' called for effect; use `mapc' or `dolist' Richard Stallman
2007-10-31 7:46 ` Richard Stallman
2007-10-31 20:30 ` Reiner Steib
2007-10-31 21:19 ` Glenn Morris
2007-11-01 2:35 ` Katsumi Yamaoka
2007-10-24 19:28 ` Reiner Steib
2007-10-24 22:18 ` Katsumi Yamaoka
2007-10-27 13:34 ` Purpose of Gnus CVS branches (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib
2007-10-29 0:36 ` Purpose of Gnus CVS branches Katsumi Yamaoka
2007-10-28 16:58 ` Warning: `mapcar' called for effect; use `mapc' or `dolist' Dan Nicolaescu
2007-11-24 22:51 ` Removing obsolete `nnmail-spool-file' (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710222007.l9MK7fRZ022140@oogie-boogie.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).