Re: Warning: `mapcar' called for effect; use `mapc' or `dolist'

[Dan Nicolaescu <dann@ics.uci.edu>]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

  > >>>>> Dan Nicolaescu wrote:
  > 
  > > The subject is about a new warning produced by the byte
  > > compiler. There's a lot of those for gnus.
  > > Assuming that all emacs versions that gnus wants to support have
  > > either mapc or dolist, can somebody please take care of these
  > > warnings?
  > 
  > > Thanks
  > 
  > With No Gnus v0.7 I did `cd lisp; make warn' and tried replacing
  > of `mapcar' with `mapc', `dolist', or `while' loops for a while,
  > and realized it's not easy and not safe.  Ones who do it will
  > need to study what things using `mapcar' do in all cases.  For
  > instance, `mapcar' used in `gnus-group-highlight-line' cannot be
  > replaced with `mapc' even if the compiler warns it.  In addition,
  > we'd better use `while' loops (or `dolist') rather than `mapc'
  > because it is faster, though it needs more work.  I think it's
  > worth working anyway but it will take time.

Thanks for doing this! Can you please also get rid of the "reference
to free variable" and the "`nnmail-spool-file' is an obsolete
variable" warnings?