From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65920 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: declare-function in files from Gnus (hashcash.el, imap.el) Date: Sat, 08 Dec 2007 14:58:50 -0800 Message-ID: <200712082258.lB8MwoBw024385@oogie-boogie.ics.uci.edu> References: <200712011634.lB1GYCkr018222@oogie-boogie.ics.uci.edu> <87mysuwdcx.fsf@neutrino.caeruleus.net> <87ac27w4lz.fsf@neutrino.caeruleus.net> <87u00eufga.fsf@neutrino.caeruleus.net> <200712022237.lB2MbNC8016800@oogie-boogie.ics.uci.edu> <200712032340.lB3Ne3Vt009200@oogie-boogie.ics.uci.edu> <53fxyg97qm.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1197154898 32341 80.91.229.12 (8 Dec 2007 23:01:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Dec 2007 23:01:38 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 09 00:01:47 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J18fv-00080a-V6 for ged-emacs-devel@m.gmane.org; Sun, 09 Dec 2007 00:01:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J18fe-00025E-Eb for ged-emacs-devel@m.gmane.org; Sat, 08 Dec 2007 18:01:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J18fY-00023W-Or for emacs-devel@gnu.org; Sat, 08 Dec 2007 18:01:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J18fY-00022d-2I for emacs-devel@gnu.org; Sat, 08 Dec 2007 18:01:12 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J18fX-00022Y-T4 for emacs-devel@gnu.org; Sat, 08 Dec 2007 18:01:11 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J18fR-00041E-JA; Sat, 08 Dec 2007 18:01:05 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id lB8MwoBw024385; Sat, 8 Dec 2007 14:58:50 -0800 (PST) In-Reply-To: (Reiner Steib's message of "Sat, 08 Dec 2007 20:42:29 +0100") Original-Lines: 22 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.24, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_42 0.60, J_CHICKENPOX_82 0.60) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84899 gmane.emacs.gnus.general:65920 Archived-At: Reiner Steib writes: > On Wed, Dec 05 2007, Glenn Morris wrote: > > > Reiner Steib wrote: > >> $ grep declare-function emacs/lisp/net/imap.el > >> (unless (fboundp 'declare-function) (defmacro declare-function (&rest r))) > > > > You need to wrap that in an (eval-and-compile), or use the --eval route. > > Okay. So can we please agree to add... > > (eval-and-compile > (unless (fboundp 'declare-function) (defmacro declare-function (&rest r)))) > > ... in the files that are synced to Gnus (like imap.el)? Sure, I added it to imap.el and hashcash.el. Is there anything else that needs this? A few more files are going to need it as soon as Glenn checks in his patch to add declare-function for the files in lisp/gnus.