Gnus development mailing list
 help / color / mirror / Atom feed
* About follup headers on usenet
@ 2008-01-11 18:37 reader
  2008-01-12  1:06 ` Reiner Steib
  0 siblings, 1 reply; 12+ messages in thread
From: reader @ 2008-01-11 18:37 UTC (permalink / raw)
  To: ding

I seem to recall seeing something in my replay headers when doing a
followup that indicated what I was following up to.

Recently I noticed my header that appears in the composition mode
shows only these headers:
  Newsgroups: comp.unix.shell
  Subject: Re: SED: replace all the underscores [...]
  From: reader@newsguy.com
  Date: Fri, 11 Jan 2008 12:32:44 -0600
  Message-ID: <87myrc43hv.fsf@newsguy.com>
  Organization: Still searching...
  User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux)
  Gcc: nnml:news.news-0108

Should there be something more?

I do have a setting in .gnus that may effect this:
  (setq message-generate-headers-first t )




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-11 18:37 About follup headers on usenet reader
@ 2008-01-12  1:06 ` Reiner Steib
  2008-01-13 15:16   ` reader
  2008-01-13 15:17   ` About follup headers on usenet reader
  0 siblings, 2 replies; 12+ messages in thread
From: Reiner Steib @ 2008-01-12  1:06 UTC (permalink / raw)
  To: ding

On Fri, Jan 11 2008, reader@newsguy.com wrote:

> I seem to recall seeing something in my replay headers when doing a
> followup that indicated what I was following up to.

References?  The References header is hidden by default in No Gnus
when composing a message.  It is inserted when sending the message.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-12  1:06 ` Reiner Steib
@ 2008-01-13 15:16   ` reader
  2008-01-13 23:00     ` Reiner Steib
  2008-01-13 15:17   ` About follup headers on usenet reader
  1 sibling, 1 reply; 12+ messages in thread
From: reader @ 2008-01-13 15:16 UTC (permalink / raw)
  To: ding

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Fri, Jan 11 2008, reader@newsguy.com wrote:
>
>> I seem to recall seeing something in my replay headers when doing a
>> followup that indicated what I was following up to.
>
> References?  The References header is hidden by default in No Gnus
> when composing a message.  It is inserted when sending the message.

Thanks... has it always been that way?  I mean in last 2yrs or so?




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-12  1:06 ` Reiner Steib
  2008-01-13 15:16   ` reader
@ 2008-01-13 15:17   ` reader
  1 sibling, 0 replies; 12+ messages in thread
From: reader @ 2008-01-13 15:17 UTC (permalink / raw)
  To: ding

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Fri, Jan 11 2008, reader@newsguy.com wrote:
>
>> I seem to recall seeing something in my replay headers when doing a
>> followup that indicated what I was following up to.
>
> References?  The References header is hidden by default in No Gnus
> when composing a message.  It is inserted when sending the message.

But it would seem this should make them appear... no?

   (setq message-generate-headers-first t )

If not that, then what mechanism?




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-13 15:16   ` reader
@ 2008-01-13 23:00     ` Reiner Steib
  2008-01-16  7:22       ` Dan Nicolaescu
  0 siblings, 1 reply; 12+ messages in thread
From: Reiner Steib @ 2008-01-13 23:00 UTC (permalink / raw)
  To: ding

On Sun, Jan 13 2008, reader@newsguy.com wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> References?  The References header is hidden by default in No Gnus
>> when composing a message.  It is inserted when sending the message.
>
> Thanks... has it always been that way?  I mean in last 2yrs or so?

Since 2004 (but as said before, only in the development version):

,----
| 2004-11-22  Romain Francoise  <romain@orebokech.com>
| 
| 	* message.el (message-header-format-alist): Add `From' in list
| 	so that it can be sorted.
| 	(message-fix-before-sending): Widen and sort headers before
| 	sending.
| 	(message-hide-headers): Use narrowing to hide headers by moving
| 	them to the top of the buffer and narrowing to the region
| 	underneath.
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-13 23:00     ` Reiner Steib
@ 2008-01-16  7:22       ` Dan Nicolaescu
  2008-01-16 18:32         ` Ted Zlatanov
  2008-01-16 21:50         ` Editing References; Bug in ` message-generate-headers'? (was: About follup headers on usenet) Reiner Steib
  0 siblings, 2 replies; 12+ messages in thread
From: Dan Nicolaescu @ 2008-01-16  7:22 UTC (permalink / raw)
  To: ding

Reiner Steib <reinersteib+gmane@imap.cc> writes:

  > On Sun, Jan 13 2008, reader@newsguy.com wrote:
  > 
  > > Reiner Steib <reinersteib+gmane@imap.cc> writes:
  > >> References?  The References header is hidden by default in No Gnus
  > >> when composing a message.  It is inserted when sending the message.
  > >
  > > Thanks... has it always been that way?  I mean in last 2yrs or so?
  > 
  > Since 2004 (but as said before, only in the development version):

And this has the bad property that even if you do
(setq message-hidden-headers nil)

and then remove the "References" header, it will still get added to the
message when the message is sent.
Is this considered a good idea?



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-16  7:22       ` Dan Nicolaescu
@ 2008-01-16 18:32         ` Ted Zlatanov
  2008-01-16 18:44           ` Dan Nicolaescu
  2008-01-16 21:54           ` reader
  2008-01-16 21:50         ` Editing References; Bug in ` message-generate-headers'? (was: About follup headers on usenet) Reiner Steib
  1 sibling, 2 replies; 12+ messages in thread
From: Ted Zlatanov @ 2008-01-16 18:32 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: ding

On Tue, 15 Jan 2008 23:22:40 -0800 Dan Nicolaescu <dann@ics.uci.edu> wrote: 

DN> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> On Sun, Jan 13 2008, reader@newsguy.com wrote:
>> 
>> > Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> >> References?  The References header is hidden by default in No Gnus
>> >> when composing a message.  It is inserted when sending the message.
>> >
>> > Thanks... has it always been that way?  I mean in last 2yrs or so?
>> 
>> Since 2004 (but as said before, only in the development version):

DN> And this has the bad property that even if you do
DN> (setq message-hidden-headers nil)

DN> and then remove the "References" header, it will still get added to the
DN> message when the message is sent.
DN> Is this considered a good idea?

I think it's OK, since 99% of users either want it or don't care.  I'd
leave it on by default.

The remaining 1% should have a clean way of removing that header I
guess.  Is there one?  I don't know of it.

Ted



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-16 18:32         ` Ted Zlatanov
@ 2008-01-16 18:44           ` Dan Nicolaescu
  2008-01-16 21:54           ` reader
  1 sibling, 0 replies; 12+ messages in thread
From: Dan Nicolaescu @ 2008-01-16 18:44 UTC (permalink / raw)
  To: Ted Zlatanov; +Cc: ding

Ted Zlatanov <tzz@lifelogs.com> writes:

  > On Tue, 15 Jan 2008 23:22:40 -0800 Dan Nicolaescu <dann@ics.uci.edu> wrote: 
  > 
  > DN> Reiner Steib <reinersteib+gmane@imap.cc> writes:
  > >> On Sun, Jan 13 2008, reader@newsguy.com wrote:
  > >> 
  > >> > Reiner Steib <reinersteib+gmane@imap.cc> writes:
  > >> >> References?  The References header is hidden by default in No Gnus
  > >> >> when composing a message.  It is inserted when sending the message.
  > >> >
  > >> > Thanks... has it always been that way?  I mean in last 2yrs or so?
  > >> 
  > >> Since 2004 (but as said before, only in the development version):
  > 
  > DN> And this has the bad property that even if you do
  > DN> (setq message-hidden-headers nil)
  > 
  > DN> and then remove the "References" header, it will still get added to the
  > DN> message when the message is sent.
  > DN> Is this considered a good idea?
  > 
  > I think it's OK, since 99% of users either want it or don't care.  I'd
  > leave it on by default.
  > 
  > The remaining 1% should have a clean way of removing that header I
  > guess.  Is there one?  I don't know of it.

Probably the code that inserts the header, should not try to insert it
if it was set to be visible, the header is in the buffer. If it is not,
then the user intentionally deleted it.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Editing References; Bug in ` message-generate-headers'? (was: About follup headers on usenet)
  2008-01-16  7:22       ` Dan Nicolaescu
  2008-01-16 18:32         ` Ted Zlatanov
@ 2008-01-16 21:50         ` Reiner Steib
  2010-04-22  8:15           ` Editing References; Bug in ` message-generate-headers'? Andreas Seltenreich
  1 sibling, 1 reply; 12+ messages in thread
From: Reiner Steib @ 2008-01-16 21:50 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: ding

On Wed, Jan 16 2008, Dan Nicolaescu wrote:

> And this has the bad property that even if you do
> (setq message-hidden-headers nil)
>
> and then remove the "References" header, it will still get added to the
> message when the message is sent.
> Is this considered a good idea?

There was some discussion abut this:

,----
| Subject: Header im message buffer
| From: Oliver Scholz <alkibia...@gmx.de>
| Date: Mon, 19 Mar 2007 19:27:50 +0100
| Message-ID: <45fed62a$0$20297$9b4e6d93@newsspool3.arcor-online.net>
| Newsgroups: de.comm.software.gnus
`----

Andreas Seltenreich proposed a patch (see below), but I didn't have
time to test it.  Anyone?

,----[ http://thread.gmane.org/87ejnblqf5.fsf@gate450.dyndns.org ]
| From: Andreas Seltenreich <andreas+ding@gate450.dyndns.org>
| Subject: dysfunctional code in message-generate-headers
| To: ding@gnus.org
| Date: Mon, 26 Mar 2007 22:07:26 +0200
| Message-ID: <87ejnblqf5.fsf@gate450.dyndns.org>
| 
| Hi,
| 
| there's some discussion in de.comm.software.gnus about an unintuitive
| behavior of Message.  Currently, a "References" header that was
| inserted on buffer creation and deleted by the user is inserted again
| when the mail is being sent.  There's also an older bug report about
| this: <news:87lkok9nnw.fsf@jidanni.org>.
| 
| Looking at the code, it seems that message-generate-headers already
| has some provision to avoid repeated insertion.  However, the code
| doesn't cause any effect at the moment, as it only puts /non-optional/
| headers into message-inserted-headers, while the check to avoid
| repeated insertion only applies to /optional/ ones.
| 
| This looks like a bug to me, and actually putting optional headers
| into message-inserted-headers as in the attached patch results in the
| behavior desired in the bug reports.
| 
| I'd like to propose this patch for No Gnus for now, since it
| essentially enables an old feature for the first time.  WDYT?
`----

--8<---------------cut here---------------start------------->8---
--- message.el	15 Mar 2007 22:41:21 -0000	7.202
+++ message.el	26 Mar 2007 00:37:08 -0000
@@ -5580,6 +5580,7 @@
 		      (if formatter
 			  (funcall formatter header value)
 			(insert header-string ": " value))
+		      (push header-string message-inserted-headers)
 		      (goto-char (message-fill-field))
 		      ;; We check whether the value was ended by a
 		      ;; newline.  If not, we insert one.
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-16 18:32         ` Ted Zlatanov
  2008-01-16 18:44           ` Dan Nicolaescu
@ 2008-01-16 21:54           ` reader
  2008-01-16 22:23             ` Reiner Steib
  1 sibling, 1 reply; 12+ messages in thread
From: reader @ 2008-01-16 21:54 UTC (permalink / raw)
  To: ding

Ted Zlatanov <tzz@lifelogs.com> writes:

> I think it's OK, since 99% of users either want it or don't care.  I'd
> leave it on by default.
>
> The remaining 1% should have a clean way of removing that header I
> guess.  Is there one?  I don't know of it.

Can it be made visible during composition?

  (setq message-generate-headers-first t )

Does not do that.




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: About follup headers on usenet
  2008-01-16 21:54           ` reader
@ 2008-01-16 22:23             ` Reiner Steib
  0 siblings, 0 replies; 12+ messages in thread
From: Reiner Steib @ 2008-01-16 22:23 UTC (permalink / raw)
  To: ding

On Wed, Jan 16 2008, reader@newsguy.com wrote:

> Can it be made visible during composition?

,----[ `C-h k <menu-bar> <Field> <Show Hidden Headers>' ]
| <menu-bar> <Field> <Show Hidden Headers> runs the command widen
|   which is an interactive built-in function in `C source code'.
| It is bound to <menu-bar> <Field> <Show Hidden Headers>, C-x n w.
| (widen)
| 
| Remove restrictions (narrowing) from current buffer.
| This allows the buffer's full text to be seen and edited.
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Editing References; Bug in ` message-generate-headers'?
  2008-01-16 21:50         ` Editing References; Bug in ` message-generate-headers'? (was: About follup headers on usenet) Reiner Steib
@ 2010-04-22  8:15           ` Andreas Seltenreich
  0 siblings, 0 replies; 12+ messages in thread
From: Andreas Seltenreich @ 2010-04-22  8:15 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: ding

Reiner Steib writes:

> On Wed, Jan 16 2008, Dan Nicolaescu wrote:
>
>> And this has the bad property that even if you do
>> (setq message-hidden-headers nil)
>>
>> and then remove the "References" header, it will still get added to the
>> message when the message is sent.
>> Is this considered a good idea?
>
[...]
> Andreas Seltenreich proposed a patch (see below), but I didn't have
> time to test it.  Anyone?

Just found this fix again while salvaging changes from my obsolete CVS
working directory.  It's been working inconspicuously for three years,
so I've grown a bit more confident it won't cause notable regressions.

Pushing it now.

regards,
andreas



^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2010-04-22  8:15 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-11 18:37 About follup headers on usenet reader
2008-01-12  1:06 ` Reiner Steib
2008-01-13 15:16   ` reader
2008-01-13 23:00     ` Reiner Steib
2008-01-16  7:22       ` Dan Nicolaescu
2008-01-16 18:32         ` Ted Zlatanov
2008-01-16 18:44           ` Dan Nicolaescu
2008-01-16 21:54           ` reader
2008-01-16 22:23             ` Reiner Steib
2008-01-16 21:50         ` Editing References; Bug in ` message-generate-headers'? (was: About follup headers on usenet) Reiner Steib
2010-04-22  8:15           ` Editing References; Bug in ` message-generate-headers'? Andreas Seltenreich
2008-01-13 15:17   ` About follup headers on usenet reader

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).