Re: New GNOME icons

[Bill Wohler <wohler@newt.com>]

Katsumi Yamaoka <yamaoka@jpl.org> wrote:

> >>>>> In <3861.1142268982@olgas.newt.com> Bill Wohler wrote:
> 
> > Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> 
> >>>>>>> In <v9fylp4zwh.fsf@marauder.physik.uni-ulm.de>
> >>>>>>>	Reiner Steib wrote:
> >>
> >>> [1]	* gmm-utils.el (gmm-image-load-path-for-library): Return single
> >>> 	directory if path is t.  Add no-error.
> >>
> >> Because of the `no-error' argument[1], I needed to modify the
> >> `gmm-defun-compat' macro as follows
> 
> > Why? The arguments to *-defun-compat shouldn't make any difference. What
> > problems were you seeing?
> 
> I'm sorry in the insufficient explanation.
> 
> The specification of the `image-load-path-for-library' function
> contained in Emacs 23 that I had checked out on yesterday
> morning (in Japan) was:
> 
> (image-load-path-for-library LIBRARY IMAGE &optional PATH)
> 
> It caused the `wrong-number-of-arguments' error since Gnus
> specifies the fourth argument NO-ERROR to the
> `gmm-image-load-path-for-library' function which is an alias to
> `image-load-path-for-library'.

Ah! I see. It was actually the image-load-path-for-library function that
was at fault, not gmm-defun-compat.

By the way, Richard had a few comments about our
image-load-path-for-library function. He didn't like that "path" was a
symbol. He preferred to pass the value. Also, he didn't like it that we
weren't always returning a list, such as when "path" was t. I think he's
right. Indeed, fixing these things simplified the final cond to just:

    (nconc (list image-directory)
           (delete image-directory (copy-sequence (or path load-path))))))

Note that we now document that the directory is first, so the "path ==
t" feature can be achieved with (car (image-load-path-for-library ...)).

I've made the changes that Richard suggested, but I'd like to get
confirmation from you folks that they are OK with you too before
committing them. At that time, you can copy the changes from
image-load-path-for-library into gmm-image-load-path-for-library and
remove your changes to gmm-defun-compat.

> >>                                     since I'm using Emacs 23.
> 
> > What's that?
> 
> Emacs 23 is being developed in the `emacs-unicode-2' branch of
> the Emacs CVS repository.  It fully uses Unicode internally for
> multilingual text, and merges the changes made in the trunk.
> (You can check it out using the `-r emacs-unicode-2' option).

Ah, that's what they're calling the Unicode branch now. I heard about
that. Is the plan to release Emacs 22, and then merge the Unicode stuff
into the trunk immediately after that? The Unicode changes would be the
major change to Emacs 23, right? I'm looking forward to that.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642