Gnus development mailing list
 help / color / mirror / Atom feed
From: Nelson Ferreira <nelson.ferreira@verizon.net>
Subject: [PATCH] -> Re: [PATCH] Problems accessing spam group (again)
Date: Tue, 08 Jun 2004 08:10:51 -0400	[thread overview]
Message-ID: <26674.0514235154$1086696678@news.gmane.org> (raw)
In-Reply-To: <m3oenuiqeb.fsf_-nf--_xmat_-m:gnus_---@tuxie.homelinux.net> (Nelson Ferreira's message of "Tue, 08 Jun 2004 01:13:00 -0400")


As I suspected, I was not fixing the right problem. It just so happens
that somehow when gnus-dup-unsupress-article gnus-data-find returns
nil for the article.

Not sure why, and still maybe not fixing the right problem, this patch now really does the trick for me.

diff -u -r7.3 gnus-dup.el
--- gnus-dup.el	20 May 2004 08:02:39 -0000	7.3
+++ gnus-dup.el	8 Jun 2004 12:10:20 -0000
@@ -154,9 +154,10 @@
 
 (defun gnus-dup-unsuppress-article (article)
   "Stop suppression of ARTICLE."
-  (let* ((header (gnus-data-header (gnus-data-find article)))
+  (let* ((art    (gnus-data-find article))
+	 (header (when art (gnus-data-header art)))
 	 (id     (when header (mail-header-id header))))
-    (when id
+    (when (and id gnus-dup-hashtb)
       (setq gnus-dup-list-dirty t)
       (setq gnus-dup-list (delete id gnus-dup-list))
       (unintern id gnus-dup-hashtb))))


"njsf" == Nelson Ferreira <nelson.ferreira@verizon.net> writes:

    njsf> Intermitently I've been getting the following error:
    njsf> Signaling: (wrong-type-argument arrayp nil)
    njsf>   gnus-dup-unsuppress-article(35829)
    njsf>   gnus-mark-article-as-unread(35829 ?$)
    njsf>   gnus-summary-mark-article(35829 ?$)
    njsf>   spam-mark-junk-as-spam-routine() spam-summary-prepare()
    njsf>   run-hooks(spam-summary-prepare) apply(run-hooks
    njsf>   spam-summary-prepare)
    njsf>   gnus-run-hooks(gnus-summary-prepare-hook)
    njsf>   gnus-summary-prepare()
    njsf>   gnus-summary-read-group-1("nnml:mail.spam" nil t nil nil
    njsf>   nil) gnus-summary-read-group("nnml:mail.spam" nil t nil
    njsf>   nil nil nil) gnus-group-read-group(nil t)
    njsf>   gnus-group-select-group(nil) gnus-topic-select-group(nil)
    njsf>   call-interactively(gnus-topic-select-group)

    njsf> I traced it to gnus-dup-unsuppress-article being called when
    njsf> gnus-dup-hashtb is not an array.

    njsf> I fixed it with the following (trivial) patch, although not
    njsf> sure if it is the solution to the real problem:


[...]


    njsf> -- Nelson Ferreira

-- 
Nelson Ferreira



       reply	other threads:[~2004-06-08 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m3oenuiqeb.fsf_-nf--_xmat_-m:gnus_---@tuxie.homelinux.net>
2004-06-08 12:10 ` Nelson Ferreira [this message]
     [not found] ` <m3r7sq6yic.fsf_-nf--_xmat_-m:gnus_---@tuxie.homelinux.net>
2004-06-08 14:21   ` Ted Zlatanov
2004-06-10 23:04     ` Nelson Ferreira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='26674.0514235154$1086696678@news.gmane.org' \
    --to=nelson.ferreira@verizon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).