Gnus development mailing list
 help / color / mirror / Atom feed
* bug: solid nnweb group
@ 1998-10-29  7:49 Shenghuo ZHU
  0 siblings, 0 replies; only message in thread
From: Shenghuo ZHU @ 1998-10-29  7:49 UTC (permalink / raw)



1. Can not make a solid nnweb group (error in the method).

2. After fixed the first bug, can not delete the groups from
nnweb-group-alist, and nnweb-group-alist is not saved when delete all
nnweb groups.

A patch is attached.

-- 
Shenghuo

:- patch ---------------------------------------
--- ChangeLog	1998/10/29 06:04:41	1.2
+++ ChangeLog	1998/10/29 07:34:57
@@ -1,3 +1,14 @@
+Thu Oct 29 01:47:44 1998  Shenghuo ZHU  <zsh@cs.rochester.edu>
+
+	* gnus-util.el (gnus-pull): Another optional argument.
+	* nnweb.el (nnweb-request-delete-group): Delete from
+	nnweb-group-alist and update active file.
+
+Thu Oct 29 01:05:08 1998  Shenghuo ZHU  <zsh@cs.rochester.edu>
+
+	* gnus-group.el (gnus-group-make-group): Accept group of new
+	method.
+
 Wed Oct 28 02:19:16 1998  Shenghuo ZHU  <zsh@cs.rochester.edu>
 
 	* gnus-agent.el (gnus-agent-fetch-group-1): Update dribble.

--- gnus-group.el	1998/10/29 05:52:30	1.1
+++ gnus-group.el	1998/10/29 06:03:14
@@ -1815,7 +1815,7 @@
     (gnus-read-method "From method: ")))
 
   (when (stringp method)
-    (setq method (gnus-server-to-method method)))
+    (setq method (or (gnus-server-to-method method) method)))
   (let* ((meth (when (and method
 			  (not (gnus-server-equal method gnus-select-method)))
 		 (if address (list (intern method) address)

--- nnweb.el	1998/10/29 06:43:43	1.1
+++ nnweb.el	1998/10/29 07:34:49
@@ -214,7 +214,8 @@
 
 (deffoo nnweb-request-delete-group (group &optional force server)
   (nnweb-possibly-change-server group server)
-  (gnus-pull group nnweb-group-alist)
+  (gnus-pull group nnweb-group-alist t)
+  (nnweb-write-active)
   (gnus-delete-file (nnweb-overview-file group))
   t)
 
--- gnus-util.el	1998/10/29 06:39:17	1.1
+++ gnus-util.el	1998/10/29 06:41:33
@@ -896,11 +896,12 @@
       (setq alist (delq entry alist)))
     alist))
 
-(defmacro gnus-pull (key alist)
+(defmacro gnus-pull (key alist &optional assoc-p)
   "Modify ALIST to be without KEY."
   (unless (symbolp alist)
     (error "Not a symbol: %s" alist))
-  `(setq ,alist (delq (assq ,key ,alist) ,alist)))
+  (let ((fun (if assoc-p 'assoc 'assq)))
+    `(setq ,alist (delq (,fun ,key ,alist) ,alist))))
 
 (defun gnus-globalify-regexp (re)
   "Returns a regexp that matches a whole line, iff RE matches a part of it."


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~1998-10-29  7:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-10-29  7:49 bug: solid nnweb group Shenghuo ZHU

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).