Gnus development mailing list
 help / color / mirror / Atom feed
From: Shenghuo ZHU <zsh@cs.rochester.edu>
Cc: ding@gnus.org
Subject: Re: [patch] Re: topic parameters and agent-score
Date: 17 Jul 1999 10:08:45 -0400	[thread overview]
Message-ID: <2n7lnz4bde.fsf@tiger.jia.vnet> (raw)
In-Reply-To: Robert Epprecht's message of "17 Jul 1999 07:29:53 +0200"

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

>>>>> "Robert" == Robert Epprecht <epprecht@sunweb.ch> writes:

Robert> BTW: I got a different backtrace this morning, which was caused for
Robert> the first time by another group. I attach it, because it might
Robert> throw some light on the issue.

Robert> ================backtrace===================
Robert> Signaling: (error "Selecting deleted buffer")
Robert>   nntp-retrieve-articles((71810 71809 71774) "de.comp.os.unix.linux.misc" "new$  gnus-retrieve-articles((71810 71809 71774) "de.comp.os.unix.linux.misc")
Robert>   gnus-agent-fetch-articles("de.comp.os.unix.linux.misc" (71810 71809 71774))
Robert>   gnus-agent-fetch-group-1("de.comp.os.unix.linux.misc" (nntp "news.sunrise.ch$  gnus-agent-fetch-session()
Robert> * call-interactively(gnus-agent-fetch-session)
Robert> ============================================

Although you get different backtrace, the reason is the same.  Read my
article <2nu2r9yvuh.fsf@tiger.jia.vnet>.  The patch in the article
fixes part of this bug. Here is another patch.  You need apply both
patches.  I hope these can fix the bug.

1999-07-17  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* nntp.el (nntp-kill-buffer): New function.
	* nntp.el: Use it to kill process buffer.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 95-zsh11.diff --]
[-- Type: text/x-patch, Size: 2101 bytes --]

--- ../../pgnus-sent/lisp/nntp.el	Tue Jul  6 10:04:38 1999
+++ nntp.el	Sat Jul 17 09:54:23 1999
@@ -292,6 +292,11 @@
       (unless discard
 	(erase-buffer)))))
 
+(defun nntp-kill-buffer (buffer)
+  (when (buffer-name buffer)
+    (kill-buffer buffer)
+    (nnheader-init-server-buffer)))
+
 (defsubst nntp-find-connection (buffer)
   "Find the connection delivering to BUFFER."
   (let ((alist nntp-connection-alist)
@@ -304,8 +309,7 @@
     (when process
       (if (memq (process-status process) '(open run))
 	  process
-	(when (buffer-name (process-buffer process))
-	  (kill-buffer (process-buffer process)))
+	(nntp-kill-buffer (process-buffer process))
 	(setq nntp-connection-alist (delq entry nntp-connection-alist))
 	nil))))
 
@@ -696,8 +700,7 @@
 	    ;; QUIT command actually is sent out before we kill
 	    ;; the process.
 	    (sleep-for 1))))
-      (when (buffer-name (process-buffer process))
-	(kill-buffer (process-buffer process)))
+      (nntp-kill-buffer (process-buffer process))
       (setq process (car (pop nntp-connection-alist))))
     (nnoo-close-server 'nntp)))
 
@@ -713,8 +716,7 @@
 	    ;; QUIT command actually is sent out before we kill
 	    ;; the process.
 	    (sleep-for 1))))
-      (when (buffer-name (process-buffer process))
-	(kill-buffer (process-buffer process))))))
+      (nntp-kill-buffer (process-buffer process)))))
 
 (deffoo nntp-request-list (&optional server)
   (nntp-possibly-change-group nil server)
@@ -846,8 +848,7 @@
 	       (nnheader-run-at-time
 		nntp-connection-timeout nil
 		`(lambda ()
-		   (when (buffer-name ,pbuffer)
-		     (kill-buffer ,pbuffer))))))
+		   (nntp-kill-buffer ,pbuffer)))))
 	 (process
 	  (condition-case ()
 	      (let ((coding-system-for-read nntp-coding-system-for-read)
@@ -873,8 +874,7 @@
 	      (let ((nnheader-callback-function nil))
 		(run-hooks 'nntp-server-opened-hook)
 		(nntp-send-authinfo t))))
-	(when (buffer-name (process-buffer process))
-	  (kill-buffer (process-buffer process)))
+	(nntp-kill-buffer (process-buffer process))
 	nil))))
 
 (defun nntp-open-network-stream (buffer)

[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


-- 
Shenghuo ZHU

  reply	other threads:[~1999-07-17 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-07-13 22:20 Robert Epprecht
1999-07-15 12:34 ` [patch] " Mike McEwan
1999-07-16 13:07   ` Robert Epprecht
1999-07-16 16:46     ` Robert Epprecht
1999-07-16 22:28       ` Mike McEwan
1999-07-17  5:29         ` Robert Epprecht
1999-07-17 14:08           ` Shenghuo ZHU [this message]
1999-07-17 20:54             ` Robert Epprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2n7lnz4bde.fsf@tiger.jia.vnet \
    --to=zsh@cs.rochester.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).