attaching a tar files don't get it encoded

attaching a tar files don't get it encoded

[Simon Josefsson]

Attaching a tar file (not gzip:ed) as archive/tar doesn't seem to
encode it with either base64 or QP, it's sent as binary data.

I though this should work, so perhaps it's me doing something
wrong. Do anyone else get this behaviour?

Repeat-by: compose new mail, C-c C-a foo.tar, RET twice, C-u M-m P.

Re: attaching a tar files don't get it encoded

[Simon Josefsson]

Simon Josefsson <jas@pdc.kth.se> writes:

> Attaching a tar file (not gzip:ed) as archive/tar doesn't seem to
> encode it with either base64 or QP, it's sent as binary data.

Sorry for following up on my own post, but I traced it and the problem
is because `find-charset-region' return 'ascii on the file contents
which make `mm-body-7-or-8' return '7bit, which make
`mm-encode-buffer' not encode the buffer at all. This last step is
wrong, becuase \0x00 is ascii (according to `find-charset-region') so
it makes Gnus send out ASCII 0 on the wire.

`mm-encode-buffer':

    ;; We force buffers that are 7bit to be unencoded, no matter
    ;; what the preferred encoding is.
    (when (eq bits '7bit)
      (setq encoding bits))

Re: attaching a tar files don't get it encoded

[Shenghuo ZHU]

>>>>> "Simon" == Simon Josefsson <jas@pdc.kth.se> writes:

Simon> Simon Josefsson <jas@pdc.kth.se> writes:
>> Attaching a tar file (not gzip:ed) as archive/tar doesn't seem to
>> encode it with either base64 or QP, it's sent as binary data.

Simon> Sorry for following up on my own post, but I traced it and the problem
Simon> is because `find-charset-region' return 'ascii on the file contents
Simon> which make `mm-body-7-or-8' return '7bit, which make
Simon> `mm-encode-buffer' not encode the buffer at all. This last step is
Simon> wrong, becuase \0x00 is ascii (according to `find-charset-region') so
Simon> it makes Gnus send out ASCII 0 on the wire.

Simon> `mm-encode-buffer':

Simon>     ;; We force buffers that are 7bit to be unencoded, no matter
Simon>     ;; what the preferred encoding is.
Simon>     (when (eq bits '7bit)
Simon>       (setq encoding bits))

Right, I just fixed it in CVS.


-- 
Shenghuo