From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/23466 Path: main.gmane.org!not-for-mail From: Shenghuo ZHU Newsgroups: gmane.emacs.gnus.general Subject: Re: p0.88 misparses 2nd-level message forwarding Date: 22 Jun 1999 21:10:10 -0400 Organization: U of Rochester Sender: owner-ding@hpc.uh.edu Message-ID: <2naetrafil.fsf@zsh.cs.rochester.edu> References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: main.gmane.org 1035161193 2137 80.91.224.250 (21 Oct 2002 00:46:33 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 00:46:33 +0000 (UTC) Cc: ding@gnus.org Return-Path: Original-Received: from farabi.math.uh.edu (farabi.math.uh.edu [129.7.128.57]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id VAA20576 for ; Tue, 22 Jun 1999 21:05:45 -0400 (EDT) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by farabi.math.uh.edu (8.9.1/8.9.1) with ESMTP id UAB10007; Tue, 22 Jun 1999 20:05:26 -0500 (CDT) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 22 Jun 1999 20:06:17 -0500 (CDT) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id UAA18419 for ; Tue, 22 Jun 1999 20:06:05 -0500 (CDT) Original-Received: from cayuga.cs.rochester.edu (cayuga.cs.rochester.edu [192.5.53.209]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id VAA20553 for ; Tue, 22 Jun 1999 21:05:02 -0400 (EDT) Original-Received: from heart.cs.rochester.edu (heart.cs.rochester.edu [192.5.53.109]) by cayuga.cs.rochester.edu (8.9.3/Q) with ESMTP id VAA20046; Tue, 22 Jun 1999 21:04:37 -0400 (EDT) Original-Received: (from zsh@localhost) by heart.cs.rochester.edu (8.9.3/8.9.3) id VAA04112; Tue, 22 Jun 1999 21:10:11 -0400 Original-To: Karl Kleinpaste X-Attribution: ZSH X-Face: 'IF:e51ib'Qbl^(}l^&4-J`'P!@[4~O|&k#:@Gld#b/]oMq&`&FVY._3+b`mzp~Jeve~/#/ ERD!OTe<86UhyN=l`mrPY)M7_}`Ktt\K+58Z!hu7>qU,i.N7TotU[FYE(f1;}`g2xj!u*l`^&=Q!g{ *q|ddto|nkt"$r,K$[)"|6,elPH= GJ6Q Original-Lines: 57 User-Agent: Gnus/5.070088 (Pterodactyl Gnus v0.88) XEmacs/20.4 (Emerald) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:23466 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:23466 --=-=-= >>>>> "KK" == Karl Kleinpaste writes: KK> 1. Send yourself a test message -- normal message, text/plain. KK> 2. Forward that message to yourself -- an inline message/rfc822. KK> 3. Forward *that* message to yourself. KK> You now have an inline message/rfc822 containing another inline KK> message/rfc822. KK> p0.88's display of this will be...confused. KK> Assuming that you prefix each forwarding with a bit of text/plain as KK> well, you will see: KK> [1. text/plain] KK> containing the "outermost" (3rd level) new text. KK> [2. message/rfc822] KK> containing nothing but (in my case) an X-Sent: header (which BTW KK> erroneously duplicates the topmost X-Sent; I sent a bug report KK> about this last week). KK> [3. text/plain] KK> containing the 2nd level text which prefaced the original message KK> on 1st forwarding... *followed by* the entire remaining message KK> displayed as text/plain, including both the 2nd level and 1st KK> level messages... all as part of a single "3." section. KK> [4. message/rfc822] KK> containing the original, 1st level forwarded message. KK> Note that the innermost, original text is duplicated in both the KK> 3. and 4. sections. Try this patch. 1999-06-22 Shenghuo ZHU * mm-view.el (mm-inline-message): Fix message view bug. * gnus-art.el (gnus-article-prepare): Ditto. --=-=-= Content-Type: application/x-patch Content-Disposition: attachment; filename=88-zsh8.diff Content-Transfer-Encoding: 8bit --- mm-view.el 1999/06/22 23:44:32 1.2 +++ mm-view.el 1999/06/23 00:04:59 @@ -158,13 +158,18 @@ (goto-char (point-min))) (defun mm-inline-message (handle) - (let ((b (point))) + (let ((b (point)) gnus-displaying-mime handles) (save-excursion (save-restriction (narrow-to-region b b) (mm-insert-part handle) - (run-hooks 'gnus-article-decode-hook) - (gnus-article-prepare-display) + (let (gnus-article-mime-handles) + (run-hooks 'gnus-article-decode-hook) + (gnus-article-prepare-display) + (setq handles gnus-article-mime-handles)) + (if handles + (setq gnus-article-mime-handles + (append gnus-article-mime-handles handles))) (mm-handle-set-undisplayer handle `(lambda () --- gnus-art.el 1999/06/22 23:50:50 1.2 +++ gnus-art.el 1999/06/23 00:04:44 @@ -2998,9 +2998,10 @@ (when (and (not ihandles) (not gnus-displaying-mime)) ;; Top-level call; we clean up. - (mm-destroy-parts gnus-article-mime-handles) - (setq gnus-article-mime-handles handles - gnus-article-mime-handle-alist nil) + (when gnus-article-mime-handles + (mm-destroy-parts gnus-article-mime-handles) + (setq gnus-article-mime-handle-alist nil)) ;; A trick. + (setq gnus-article-mime-handles handles) ;; We allow users to glean info from the handles. (when gnus-article-mime-part-function (gnus-mime-part-function handles))) --=-=-= KK> Perhaps significantly, the buttonized (`K b') display of these KK> sections will show the button areas as KK> [1. text/plain] in *bold* KK> [2. message/rfc822] in *bold* KK> [3. text/plain] in /italic/ KK> [4. message/rfc822] in *bold* KK> Shouldn't these be labelled something hierarchical anyway, such as 1., KK> 2., 2.1, 2.2, 2.2.1? It is difficult. The label is used as the argument of gnus-article-view-part (press 'b'). -- Shenghuo ZHU --=-=-=--