Gnus development mailing list
 help / color / mirror / Atom feed
From: Shenghuo ZHU <zsh@cs.rochester.edu>
Subject: EOL bug in attaching binary file
Date: 04 Nov 1999 22:40:01 -0500	[thread overview]
Message-ID: <2niu3hehda.fsf@tiger.jia.vnet> (raw)

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]


pGnus in XEmacs may corrupt attached binary file. It seems OK for
pGnus in Emacs.

This (committed) patch is highly recommended if you are using pGnus in
XEmacs. 

-- 
Shenghuo

1999-11-04 22:20:35  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* mml.el (mml-generate-mime-1): Read attached binary file in
 	binary mode.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 97-122.diff --]
[-- Type: text/x-patch, Size: 740 bytes --]

Index: mml.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mml.el,v
retrieving revision 5.29
retrieving revision 5.30
diff -u -r5.29 -r5.30
--- mml.el	1999/09/27 15:19:03	5.29
+++ mml.el	1999/11/05 03:36:48	5.30
@@ -242,7 +242,8 @@
 	    (insert-buffer-substring (cdr (assq 'buffer cont))))
 	   ((and (setq filename (cdr (assq 'filename cont)))
 		 (not (equal (cdr (assq 'nofile cont)) "yes")))
-	    (mm-insert-file-contents filename nil nil nil nil t))
+	    (let ((coding-system-for-read mm-binary-coding-system))
+	      (mm-insert-file-contents filename nil nil nil nil t)))
 	   (t
 	    (insert (cdr (assq 'contents cont)))))
 	  (setq encoding (mm-encode-buffer type)

                 reply	other threads:[~1999-11-05  3:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2niu3hehda.fsf@tiger.jia.vnet \
    --to=zsh@cs.rochester.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).