From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/26185 Path: main.gmane.org!not-for-mail From: Shenghuo ZHU Newsgroups: gmane.emacs.gnus.general Subject: EOL bug in attaching binary file Date: 04 Nov 1999 22:40:01 -0500 Organization: U of Rochester Sender: owner-ding@hpc.uh.edu Message-ID: <2niu3hehda.fsf@tiger.jia.vnet> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: main.gmane.org 1035163442 18079 80.91.224.250 (21 Oct 2002 01:24:02 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 01:24:02 +0000 (UTC) Return-Path: Original-Received: from lisa.math.uh.edu (lisa.math.uh.edu [129.7.128.49]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id WAA16262 for ; Thu, 4 Nov 1999 22:44:14 -0500 (EST) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by lisa.math.uh.edu (8.9.1/8.9.1) with ESMTP id VAB21140; Thu, 4 Nov 1999 21:44:00 -0600 (CST) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 04 Nov 1999 21:43:57 -0600 (CST) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id VAA14991 for ; Thu, 4 Nov 1999 21:43:47 -0600 (CST) Original-Received: from cayuga.cs.rochester.edu (cayuga.cs.rochester.edu [192.5.53.209]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id WAA16242 for ; Thu, 4 Nov 1999 22:43:16 -0500 (EST) Original-Received: from heart.cs.rochester.edu (heart.cs.rochester.edu [192.5.53.109]) by cayuga.cs.rochester.edu (8.9.3/Q) with ESMTP id WAA20639 for ; Thu, 4 Nov 1999 22:43:07 -0500 (EST) Original-Received: (from zsh@localhost) by heart.cs.rochester.edu (8.9.3/8.9.3) id WAA01323; Thu, 4 Nov 1999 22:40:01 -0500 Original-To: Gnus Mailing List X-Attribution: ZSH X-Face: 'IF:e51ib'Qbl^(}l^&4-J`'P!@[4~O|&k#:@Gld#b/]oMq&`&FVY._3+b`mzp~Jeve~/#/ ERD!OTe<86UhyN=l`mrPY)M7_}`Ktt\K+58Z!hu7>qU,i.N7TotU[FYE(f1;}`g2xj!u*l`^&=Q!g{ *q|ddto|nkt"$r,K$[)"|6,elPH= GJ6Q Original-Lines: 17 User-Agent: Gnus/5.07009701 (Pterodactyl Gnus v0.97.1) XEmacs/21.2 (Shinjuku) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:26185 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:26185 --=-=-= pGnus in XEmacs may corrupt attached binary file. It seems OK for pGnus in Emacs. This (committed) patch is highly recommended if you are using pGnus in XEmacs. -- Shenghuo 1999-11-04 22:20:35 Shenghuo ZHU * mml.el (mml-generate-mime-1): Read attached binary file in binary mode. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=97-122.diff Index: mml.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/mml.el,v retrieving revision 5.29 retrieving revision 5.30 diff -u -r5.29 -r5.30 --- mml.el 1999/09/27 15:19:03 5.29 +++ mml.el 1999/11/05 03:36:48 5.30 @@ -242,7 +242,8 @@ (insert-buffer-substring (cdr (assq 'buffer cont)))) ((and (setq filename (cdr (assq 'filename cont))) (not (equal (cdr (assq 'nofile cont)) "yes"))) - (mm-insert-file-contents filename nil nil nil nil t)) + (let ((coding-system-for-read mm-binary-coding-system)) + (mm-insert-file-contents filename nil nil nil nil t))) (t (insert (cdr (assq 'contents cont))))) (setq encoding (mm-encode-buffer type) --=-=-=--