* gnus-mime-copy-part and filename
@ 2002-11-17 21:41 Kevin Ryde
2002-11-27 1:52 ` ShengHuo ZHU
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Ryde @ 2002-11-17 21:41 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
I notice gnus-mime-copy-part (`c' on the button) looks for a filename
parameter from mm-handle-type, but I wonder if that ought to be
mm-handle-disposition.
Certainly gnus itself seems to give the filename under
Content-Disposition rather than Content-Type, following rfc2183 if I
read it right.
Fixing this lets normal-mode do the right thing in the new buffer.
* gnus-art.el (gnus-mime-copy-part): Look for filename
parameter under content-disposition, not content-type.
[-- Attachment #2: gnus-art.el.copy-part.diff --]
[-- Type: text/plain, Size: 458 bytes --]
--- gnus-art.el.~6.253.~ 2002-11-18 06:06:02.000000000 +1000
+++ gnus-art.el 2002-11-18 07:34:34.000000000 +1000
@@ -3878,7 +3878,7 @@
(file-name-nondirectory
(or
(mail-content-type-get (mm-handle-type handle) 'name)
- (mail-content-type-get (mm-handle-type handle)
+ (mail-content-type-get (mm-handle-disposition handle)
'filename)
"*decoded*"))))
(buffer (and base (generate-new-buffer base))))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gnus-mime-copy-part and filename
2002-11-17 21:41 gnus-mime-copy-part and filename Kevin Ryde
@ 2002-11-27 1:52 ` ShengHuo ZHU
0 siblings, 0 replies; 2+ messages in thread
From: ShengHuo ZHU @ 2002-11-27 1:52 UTC (permalink / raw)
Kevin Ryde <user42@zip.com.au> writes:
> I notice gnus-mime-copy-part (`c' on the button) looks for a filename
> parameter from mm-handle-type, but I wonder if that ought to be
> mm-handle-disposition.
>
> Certainly gnus itself seems to give the filename under
> Content-Disposition rather than Content-Type, following rfc2183 if I
> read it right.
>
> Fixing this lets normal-mode do the right thing in the new buffer.
>
> * gnus-art.el (gnus-mime-copy-part): Look for filename
> parameter under content-disposition, not content-type.
Installed.
ShengHuo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-11-27 1:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-17 21:41 gnus-mime-copy-part and filename Kevin Ryde
2002-11-27 1:52 ` ShengHuo ZHU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).