problem in `nnheader-report'?

problem in `nnheader-report'?

[Colin Walters]

In CVS, there seems to be a problem with either the function
`nnheader-report', or some of the calls to it in
`nntp-retrieve-groups'.  For example, the code:

(unless (gnus-buffer-live-p buf)
	  (error
	   (nnheader-report 'nntp "Connection to %s is closed." server)))

in nntp.el seems to expect nnheader-report to return a string, but it
currently always returns nil.  So here's a patch which should make it
return the string.  I'm not sure if this is the correct fix or not,
but it seems to work.

2001-04-30  Colin Walters  <walters@cis.ohio-state.edu>

	* nnheader.el (nnheader-report): Return the string instead of nil.

diff -u /usr/local/share/emacs/site-lisp/gnus/nnheader.el\~ /usr/local/share/emacs/site-lisp/gnus/nnheader.el
--- /usr/local/share/emacs/site-lisp/gnus/nnheader.el~	Mon Apr 30 14:42:45 2001
+++ /usr/local/share/emacs/site-lisp/gnus/nnheader.el	Mon Apr 30 14:57:26 2001
@@ -687,8 +687,7 @@
   (set (intern (format "%s-status-string" backend))
        (if (< (length args) 2)
 	   (car args)
-	 (apply 'format args)))
-  nil)
+	 (apply 'format args))))
 
 (defun nnheader-get-report (backend)
   "Get the most recent report from BACKEND."

Re: problem in `nnheader-report'?

[ShengHuo ZHU]

Colin Walters <walters@cis.ohio-state.edu> writes:

> In CVS, there seems to be a problem with either the function
> `nnheader-report', or some of the calls to it in
> `nntp-retrieve-groups'.  For example, the code:
> 
> (unless (gnus-buffer-live-p buf)
> 	  (error
> 	   (nnheader-report 'nntp "Connection to %s is closed." server)))
> 
> in nntp.el seems to expect nnheader-report to return a string, but it
> currently always returns nil.  So here's a patch which should make it
> return the string.  I'm not sure if this is the correct fix or not,
> but it seems to work.

It's my fault for adding these error codes. Actually, nnheader-report
should always return nil, because most backends use nnheader-report to
return nil.  I'll install a patch in minutes.

ShengHuo