0.97: bug while sending mail

0.97: bug while sending mail

[Vladimir Volovich]

Hi,

while trying to send my previous mail, i've got the following error
when pressed C-c C-c. It was triggered by presence of a latin-1
character in Francois' name... (after replacing that char with ASCII
analog, error disappeared).

Signaling: (end-of-buffer)
  quoted-printable-encode-region(1 3035 t)
  mm-encode-content-transfer-encoding(quoted-printable "text/plain")
  mm-body-encoding(iso-8859-1)
  mml-generate-mime-1((part (type . "text/plain") (contents . "\"FP\" == Fran\x8e7ois Pinard writes:\n\n >> message-newline-and-reformat (M-RET) does not work with supercited\n >> messages, which is very inconvenient: i find this function VERY\n >> useful in general, so it would be great to make it SC-aware.\n\n FP> How do you use it?\n\nwell, i just put cursor to the place where i wish to break the quote,\nand press M-RET (as i did just now ;). Then gnus automagically inserts\na prefix (` FP> ' in this case) behind the first line, and re-formats\nthe rest of the quoted paragraph (making it both look beautigul and\nreserving a bit of space :), and puts the point in the convenient\nplace, so i can type an answer immediately without moving cursor.\n\n FP> I just tried it, and it seems be convenient for inserting\n FP> comments within a reply, maybe.  Yet, it leaves two white lines\n FP> before point, which is surely one too much.  Also, it does not\n FP> seem to properly discov
 e!
!
r the fill prefix for the following\n FP> paragraph, at least in my little tries.  The amount of extra work\n FP> needed to repair these things, even if tiny, outweighs the\n FP> benefits of using the command, at first glance.  But since you\n FP> underlined `VERY', above, I guess I may be missing something?\n FP> :-)\n\nWell, did you re-defined the message-newline-and-reformat function\nbefore trying? Let me give an example of how it works for me.\n\n1) the quoted paragraph, as it looked after following up (prepared by\n   supercite). Cursor is shown by `_' (at the first line, just after\n   the question sign), and is at the place where i wished to insert a\n   reply:\n\n FP> How do you use it?_ I just tried it, and it seems be convenient\n FP> for inserting comments within a reply, maybe.  Yet, it leaves two\n FP> white lines before point, which is surely one too much.  Also, it\n FP> does not seem to properly discover the fill prefix for the\n FP> following paragraph, at l
 e!
!
ast in my little tries.  The amount of\n FP> extra work needed to repair these things, even if tiny, outweighs\n FP> the benefits of using the command, at first glance.  But since\n FP> you underlined `VERY', above, I guess I may be missing something?\n FP> :-)\n\n2) when i press M-RET, the paragraph looks like:\n\n FP> How do you use it?\n\n_\n\n FP> I just tried it, and it seems be convenient for inserting\n FP> comments within a reply, maybe.  Yet, it leaves two white lines\n FP> before point, which is surely one too much.  Also, it does not\n FP> seem to properly discover the fill prefix for the following\n FP> paragraph, at least in my little tries.  The amount of extra work\n FP> needed to repair these things, even if tiny, outweighs the\n FP> benefits of using the command, at first glance.  But since you\n FP> underlined `VERY', above, I guess I may be missing something?\n FP> :-)\n\nNote that the rest of the quote was micely reformatted, and cursor was\nput at the con
 v!
!
enient place. Doesn't this work for you?\n\n	Best regards, -- Vladimir.\n-- \n	\"What terrible way to die.\"\n	\"There are no good ways.\"\n		-- Sulu and Kirk, \"That Which Survives\", stardate unknown\n")))
  mml-generate-mime()
  message-encode-message-body()
  message-send-mail(nil)
  message-send-via-mail(nil)
  message-send(nil)
  message-send-and-exit(nil)
* call-interactively(message-send-and-exit)

	Best regards, -- Vladimir.
-- 
The day advanced as if to light some work of mine; it was morning, 
and lo! now it is evening, and nothing memorable is accomplished.  
		-- H.D. Thoreau

Re: 0.97: bug while sending mail

[Shenghuo ZHU]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

>>>>> "VV" == Vladimir Volovich <vvv@vvv.vsu.ru> writes:

VV> Hi,
VV> while trying to send my previous mail, i've got the following error
VV> when pressed C-c C-c. It was triggered by presence of a latin-1
VV> character in Francois' name... (after replacing that char with ASCII
VV> analog, error disappeared).

[...]

This happens in a blue moon, latin-1 characters in the message and the
last line contains 72 characters.

A patch follows. (Committed)

-- 
Shenghuo ZHU

1999-10-05  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* qp.el (quoted-printable-encode-region): Check eobp.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 97-zsh5.diff --]
[-- Type: text/x-patch, Size: 660 bytes --]

Index: qp.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/qp.el,v
retrieving revision 5.11
diff -u -r5.11 qp.el
--- qp.el	1999/09/27 15:19:05	5.11
+++ qp.el	1999/10/05 07:40:04
@@ -99,11 +99,12 @@
 	  (end-of-line)
 	  (while (> (current-column) 72)
 	    (beginning-of-line)
-	    (forward-char 72)
+	    (forward-char 71) ;; 71 char plus an "="
 	    (search-backward "=" (- (point) 2) t)
 	    (insert "=\n")
 	    (end-of-line))
-	  (forward-line))))))
+	  (unless (eobp)
+	    (forward-line)))))))
 
 (defun quoted-printable-encode-string (string)
  "QP-encode STRING and return the results."