From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/32229
Path: main.gmane.org!not-for-mail
From: ShengHuo ZHU <zsh@cs.rochester.edu>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: fix for char-int lossage in message-make-caesar-translation-table
Date: 18 Aug 2000 16:55:56 -0400
Sender: owner-ding@hpc.uh.edu
Message-ID: <2nn1iaxp9f.fsf@tiger.jia.vnet>
References: <200008182037.PAA00461@buffalo.fnal.gov>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1035168532 18539 80.91.224.250 (21 Oct 2002 02:48:52 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 02:48:52 +0000 (UTC)
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from spinoza.math.uh.edu (spinoza.math.uh.edu [129.7.128.18])
	by mailhost.sclp.com (Postfix) with ESMTP id 43280D051E
	for <jason@mailhost.sclp.com>; Fri, 18 Aug 2000 16:58:28 -0400 (EDT)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by spinoza.math.uh.edu (8.9.1/8.9.1) with ESMTP id PAC21971;
	Fri, 18 Aug 2000 15:58:08 -0500 (CDT)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Fri, 18 Aug 2000 15:55:08 -0500 (CDT)
Original-Received: from mailhost.sclp.com (postfix@66-209.196.61.interliant.com [209.196.61.66] (may be forged))
	by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id PAA13651
	for <ding@hpc.uh.edu>; Fri, 18 Aug 2000 15:54:58 -0500 (CDT)
Original-Received: from shenghuo.dhs.org (d18182975.rochester.rr.com [24.24.41.117])
	by mailhost.sclp.com (Postfix) with ESMTP id 34EC8D051E
	for <ding@gnus.org>; Fri, 18 Aug 2000 16:55:27 -0400 (EDT)
Original-Received: (from zsh@localhost)
	by shenghuo.dhs.org (8.10.0/8.10.0) id e7IKtvr10618;
	Fri, 18 Aug 2000 16:55:57 -0400
Original-To: ding@gnus.org
X-Attribution: ZSH
X-Face: 'IF:e51ib'Qbl^(}l^&4-J`'P!@[4~O|&k#:@Gld#b/]oMq&`&FVY._3+b`mzp~Jeve~/#/
 ERD!OTe<86UhyN=l`mrPY)M7_}`Ktt\K+58Z!hu7>qU,i.N7TotU[FYE(f1;}`g2xj!u*l`^&=Q!g{
 *q|<EDbQtg9{wfQuI,#r#{'A,\!95my:/,]"s,O4nzqxNL.}WrHA>ddto|nkt"$r,K$[)"|6,elPH=
 GJ6Q
In-Reply-To: Charles G Waldman's message of "Fri, 18 Aug 2000 15:37:44 -0500"
Original-Lines: 24
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:32229
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:32229

Charles G Waldman <cgw@fnal.gov> writes:

> Decoding rot-13 messages in Gnus fails on XEmacs because the
> function message-make-caesar-translation-table was using character
> constants as indices for the `substring' function, which is
> expecting an int.  FSF Emacs may let you carelessly mix chars and
> ints, but XEmacs won't.
> 
> I also changed some bizarre arithmetic.  Where I come from, x + n +
> 26 - n is usually referred to as x + 26.
> 
> 
> ChangeLog for gnus/lisp:
> 
> Fri Aug 18 15:35:03 2000  Charles G. Waldman  <cgw@alum.mit.edu>
> 	* message.el (message-make-caesar-translation-table):
> 	Don't use chars as ints.  Simplify arithmetic.

This patch is not necessary.  

In XEmacs, message-xmas-make-caesar-translation-table (messagexmas.el)
is used instead of message-make-caesar-translation-table.

ShengHuo