Re: Stringp-error when retrieving grouplist from news.newsfeeds.com

Re: Stringp-error when retrieving grouplist from news.newsfeeds.com

[Shenghuo ZHU]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

>>>>> "AM" == Andrew Markebo <andrew.markebo@telelogic.se> writes:

AM> Pterodactyl Gnus v0.97
AM> GNU Emacs 20.4.2 (sparc-sun-solaris2.5.1, X toolkit)
AM>  of Thu Jul 22 1999 on warp
AM> 200 127.0.0.1 DNEWS Version 5.2c, S7, posting OK 

AM> What I did was ^ to enter the server buffer, jumped to
AM> news.newsfeeds.com, enter.. chew chew chew.. whammo

AM> Connecting to news.newsfeeds.com...
AM> Reading active file...

AM> Reading active file...done
AM> Wrong type argument: stringp, 100622.2474

AM>         /Andy

AM> It is a huge list of articles.. here comes the backtrace:

AM> Signaling: (wrong-type-argument stringp 100622.2474)
AM>   #[(l1 l2) "\b@	@(TM)‡" [l1 l2] 2]((100622.2474 . 1) (1a . 1))
AM>   sort(((ercielt . 1) (erg2310b . 1) (ernmc\.firewall-1 . 1238) 

[...]

AM>   gnus-browse-foreign-server("news.newsfeeds.com" #<buffer *Server*>)
AM>   gnus-server-read-server("news.newsfeeds.com")
AM>   call-interactively(gnus-server-read-server)

I guess I've fixed it. The weird behavior is because of the all-digit
group.  Could you test the patch (committed) ?

-- 
Shenghuo

1999-10-26 21:44:05  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* gnus-srvr.el (gnus-browse-foreign-server): Use
 	`buffer-substring' instead of `read'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 97-115.diff --]
[-- Type: text/x-patch, Size: 635 bytes --]

Index: gnus-srvr.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-srvr.el,v
retrieving revision 5.11
diff -u -r5.11 gnus-srvr.el
--- gnus-srvr.el	1999/09/27 15:18:52	5.11
+++ gnus-srvr.el	1999/10/27 01:43:55
@@ -594,7 +594,9 @@
 	    (delete-matching-lines gnus-ignored-newsgroups))
 	  (while (not (eobp)) 
 	    (ignore-errors
-             (push (cons (read cur)
+             (push (cons (let ((p (point)))
+			   (skip-chars-forward "^ \t")
+			   (buffer-substring p (point)))
 			  (max 0 (- (1+ (read cur)) (read cur))))
 		    groups))
 	    (forward-line))))

An un-decoded-QP bug and its patch (was: Re: Stringp-error when retrieving grouplist from news.newsfeeds.com)

[Shenghuo ZHU]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]


In my last mail, some QP-encoded stuffs show in the article buffer.
Here is a (committed) patch fixing it.

-- 
Shenghuo ZHU

1999-10-26 23:27:44  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* mm-decode.el (mm-dissect-buffer): CTE may come without CTL.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 97-116.diff --]
[-- Type: text/x-patch, Size: 726 bytes --]

Index: mm-decode.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mm-decode.el,v
retrieving revision 5.52
diff -u -r5.52 mm-decode.el
--- mm-decode.el	1999/09/27 15:19:03	5.52
+++ mm-decode.el	1999/10/27 03:26:46
@@ -190,7 +190,11 @@
       (if (or (not ctl)
 	      (not (string-match "/" (car ctl))))
 	  (mm-dissect-singlepart
-	   '("text/plain") nil no-strict-mime
+	   '("text/plain") 
+	   (and cte (intern (downcase (mail-header-remove-whitespace
+				       (mail-header-remove-comments
+					cte)))))
+	   no-strict-mime
 	   (and cd (ignore-errors (mail-header-parse-content-disposition cd)))
 	   description)
 	(setq type (split-string (car ctl) "/"))