Re: Gnus and \202 in Article buffer again

Re: Gnus and \202 in Article buffer again

[Pavel Janík]

[-- Attachment #1: Type: text/plain, Size: 3244 bytes --]

   From: Pavel@Janik.cz (Pavel Janík)
   Date: Tue, 10 Jul 2001 14:13:06 +0200

Hi again,

this is a reply to my own e-mail with a full copy for you who do not read
the list where I reported this problem originally.

   > I have done a cvs update/recompile tonight as I usually do and from that
   > time, I do have \202 before accented characters the body of each message in
   > the Article buffer. I run emacs with LANG=cs_CZ and a minute before
   > checkout, it used to work without any problem. I have stripped down my dot
   > files to a bare minimum and can also reproduce the problem with it. All
   > (really, I have tested it with a just created user without any other files
   > in his ~) you need is in the attached file:
   > 
   > drwxr-xr-x user/users        0 2001-07-10 13:52:37 Mail/
   > -rwxr-xr-x user/users       15 2001-07-10 13:52:37 Mail/active
   > -rwxr-xr-x user/users      672 2001-07-10 13:52:25 Mail/Incoming
   > -rw-r--r-- user/users     2158 2001-07-10 13:56:45 .newsrc.eld
   > 
   > Mail/ directory with one folder Incoming and active file. Incoming folder
   > contains just one message which contains correct MIME headers.
   > 
   > .newsrc.eld file is set up so you can simply run:
   > 
   > LANG=cs_CZ emacs -f gnus
   > 
   > After that, just press y to an error message and display an article from
   > Incoming. You will see
   > http://www.janik.cz/tmp/emacs-gnus-21.0.104-problem.png.
   > 
   > Do you see the same? I do not think that this is bug in Gnus, because the
   > same bug can be seen with Oort Gnus from CVS. I can provide any details you
   > want.

Hmm, after spending the whole evening on this, I know what is the
cause. This patch (which reverts Gerd's patch) can fix this problem for me:

diff -urN emacs-21.0.104.orig/lisp/gnus/ChangeLog emacs-21.0.104/lisp/gnus/ChangeLog
--- emacs-21.0.104.orig/lisp/gnus/ChangeLog	Wed Jul 11 22:50:15 2001
+++ emacs-21.0.104/lisp/gnus/ChangeLog	Wed Jul 11 22:51:12 2001
@@ -1,8 +1,3 @@
-2001-07-04  Gerd Moellmann  <gerd@gnu.org>
-
-	* nnheader.el (nnheader-init-server-buffer): Make sure the
-	*nntpd* buffer is made multibyte instead of a random buffer.
-
 2001-07-02  Eli Zaretskii  <eliz@is.elta.co.il>
 
 	* gnus.el: Fix the header line, for finder.el.  Suggested by
diff -urN emacs-21.0.104.orig/lisp/gnus/nnheader.el emacs-21.0.104/lisp/gnus/nnheader.el
--- emacs-21.0.104.orig/lisp/gnus/nnheader.el	Wed Jul 11 22:50:14 2001
+++ emacs-21.0.104/lisp/gnus/nnheader.el	Wed Jul 11 22:51:13 2001
@@ -474,8 +474,8 @@
   (save-excursion
     (unless (gnus-buffer-live-p nntp-server-buffer)
       (setq nntp-server-buffer (get-buffer-create " *nntpd*")))
-    (set-buffer nntp-server-buffer)
     (mm-enable-multibyte)
+    (set-buffer nntp-server-buffer)
     (erase-buffer)
     (kill-all-local-variables)
     (setq case-fold-search t)		;Should ignore case.


First, I thought that this is problem in Emacs itself, but this Gerd's
patch was commited to both CVS Gnus and to CVS of Emacs so I was fooled :-)
I do not know what is the correct solution though. Will leave this on
Shenghuo and Gerd. Uff ;-)
-- 
Pavel Janík

printk("autofs: Out of inode numbers -- what the heck did you do??\n"); 
                  -- 2.0.38 fs/autofs/root.c

[-- Attachment #2: gnus-debug.tar.gz --]
[-- Type: application/x-gzip, Size: 1444 bytes --]

Re: Gnus and \202 in Article buffer again

[Gerd Moellmann]

Pavel@Janik.cz (Pavel Janík) writes:

> diff -urN emacs-21.0.104.orig/lisp/gnus/ChangeLog emacs-21.0.104/lisp/gnus/ChangeLog
> --- emacs-21.0.104.orig/lisp/gnus/ChangeLog	Wed Jul 11 22:50:15 2001
> +++ emacs-21.0.104/lisp/gnus/ChangeLog	Wed Jul 11 22:51:12 2001
> @@ -1,8 +1,3 @@
> -2001-07-04  Gerd Moellmann  <gerd@gnu.org>
> -
> -	* nnheader.el (nnheader-init-server-buffer): Make sure the
> -	*nntpd* buffer is made multibyte instead of a random buffer.
> -
>  2001-07-02  Eli Zaretskii  <eliz@is.elta.co.il>
>  
>  	* gnus.el: Fix the header line, for finder.el.  Suggested by
> diff -urN emacs-21.0.104.orig/lisp/gnus/nnheader.el emacs-21.0.104/lisp/gnus/nnheader.el
> --- emacs-21.0.104.orig/lisp/gnus/nnheader.el	Wed Jul 11 22:50:14 2001
> +++ emacs-21.0.104/lisp/gnus/nnheader.el	Wed Jul 11 22:51:13 2001
> @@ -474,8 +474,8 @@
>    (save-excursion
>      (unless (gnus-buffer-live-p nntp-server-buffer)
>        (setq nntp-server-buffer (get-buffer-create " *nntpd*")))
> -    (set-buffer nntp-server-buffer)
>      (mm-enable-multibyte)
> +    (set-buffer nntp-server-buffer)
>      (erase-buffer)
>      (kill-all-local-variables)
>      (setq case-fold-search t)		;Should ignore case.
> 
> 
> First, I thought that this is problem in Emacs itself, but this Gerd's
> patch was commited to both CVS Gnus and to CVS of Emacs so I was fooled :-)
> I do not know what is the correct solution though. Will leave this on
> Shenghuo and Gerd. Uff ;-)

What I fixed is clearly a bug; Kenichi reported that M-x gnus can
change the multibyteness of random buffers.  Probably fixing that
bug uncovered another.

Re: Gnus and \202 in Article buffer again

[ShengHuo ZHU]

gerd.moellmann@t-online.de (Gerd Moellmann) writes:

>> First, I thought that this is problem in Emacs itself, but this Gerd's
>> patch was commited to both CVS Gnus and to CVS of Emacs so I was fooled :-)
>> I do not know what is the correct solution though. Will leave this on
>> Shenghuo and Gerd. Uff ;-)
> 
> What I fixed is clearly a bug; Kenichi reported that M-x gnus can
> change the multibyteness of random buffers.  Probably fixing that
> bug uncovered another.

Yes. It is the case.

ShengHuo

Re: Gnus and \202 in Article buffer again

[ShengHuo ZHU]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

Pavel@Janik.cz (Pavel Janík) writes:

>    From: Pavel@Janik.cz (Pavel Janík)
>    Date: Tue, 10 Jul 2001 14:13:06 +0200
> 
> Hi again,
> 
> this is a reply to my own e-mail with a full copy for you who do not read
> the list where I reported this problem originally.
> 
>   > I have done a cvs update/recompile tonight as I usually do and from that
>   > time, I do have \202 before accented characters the body of each message in

[...]

> First, I thought that this is problem in Emacs itself, but this Gerd's
> patch was commited to both CVS Gnus and to CVS of Emacs so I was fooled :-)
> I do not know what is the correct solution though. Will leave this on
> Shenghuo and Gerd. Uff ;-)

This bug is only related to nnfolder backend. I've fixed it in the
Gnus CVS.  Please test before add it to the Emacs CVS.

ShengHuo

2001-07-11 18:00:00  ShengHuo ZHU  <zsh@cs.rochester.edu>

	* nnfolder.el (nnfolder-read-folder): Force to use a multibyte buffer.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: nnfolder.el.diff --]
[-- Type: text/x-patch, Size: 666 bytes --]

Index: nnfolder.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnfolder.el,v
retrieving revision 6.9
retrieving revision 6.10
diff -u -u -r6.9 -r6.10
--- nnfolder.el	2001/07/10 17:49:44	6.9
+++ nnfolder.el	2001/07/12 01:14:49	6.10
@@ -795,6 +795,7 @@
 		  (let ((nnheader-file-coding-system 
 			 nnfolder-file-coding-system))
 		    (nnheader-find-file-noselect file)))))
+    (mm-enable-multibyte) ;; Use multibyte buffer for future copying.
     (if (equal (cadr (assoc group nnfolder-scantime-alist))
 	       (nth 5 (file-attributes file)))
 	;; This looks up-to-date, so we don't do any scanning.

Re: Gnus and \202 in Article buffer again

[Pavel Janík]

   From: ShengHuo ZHU <zsh@cs.rochester.edu>
   Date: Wed, 11 Jul 2001 18:20:33 -0700

Hi,

   > This bug is only related to nnfolder backend. I've fixed it in the
   > Gnus CVS.  Please test before add it to the Emacs CVS.

I have tested it with both CVS Gnus and with 5.9.0 and it works for
me. I think, it can be applied. Thank you.
-- 
Pavel Janík

You're right, this should be fixed. Do you happen to have a patch?
                  -- Rik van Riel in linux-kernel about VM bug

Re: Gnus and \202 in Article buffer again

[Gerd Moellmann]

Pavel@Janik.cz (Pavel Janík) writes:

> I have tested it with both CVS Gnus and with 5.9.0 and it works for
> me. I think, it can be applied.

Done.