Re: Mouse-2 on e-mail in From: header?

[ShengHuo ZHU <zsh@cs.rochester.edu>]

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

Pavel@Janik.cz (Pavel Janík) writes:

> Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 519>)
>   select-window(#<window 519>)
>   widget-button-click((down-mouse-2 (#<window 519> 39 (266 . 6) -132791712)))
>   call-interactively(widget-button-click)

Pavel@Janik.cz (Pavel Janík) writes:

>    From: Simon Josefsson <jas@extundo.com>
>    Date: Fri, 14 Sep 2001 21:39:35 +0200
>
> Hi,
>
>    > Maybe you could try applying the diff's between gnus-art.el in pretest
>    > and the one in CVS incrementally to find what change caused this?
>    > Assuming it is gnus-art.el which causes this..
>
> OK, running with Gnus 5.9.0 with gnus-msg.el and gnus.el is OK (at least
> for this particular problem). After applying the following patch:


The problem is because the button-click function changes the window
configuration, however, in widget-button-click, there is a
save-selected-window.  The attached workaround fixes the problem.

Gerd, what is the reason to save the selected window around the code
handling clicks on buttons in widget-button-click?  Is the workaround
appropriate?

ShengHuo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-msg.el.diff --]
[-- Type: text/x-patch, Size: 1233 bytes --]

Index: gnus-msg.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-msg.el,v
retrieving revision 6.46
diff -u -r6.46 gnus-msg.el
--- gnus-msg.el	2001/08/20 18:54:43	6.46
+++ gnus-msg.el	2001/09/15 02:41:26
@@ -322,19 +322,27 @@
   ;; COMPOSEFUNC should return t if succeed.  Undocumented ???
   t)
 
+(defvar save-selected-window-window)
+
 ;;;###autoload
 (defun gnus-button-mailto (address)
   "Mail to ADDRESS."
   (set-buffer (gnus-copy-article-buffer))
   (gnus-setup-message 'message
-    (message-reply address)))
+    (message-reply address))
+  (and (boundp 'save-selected-window-window)
+       (not (window-live-p save-selected-window-window))
+       (setq save-selected-window-window (selected-window))))
 
 ;;;###autoload
 (defun gnus-button-reply (&optional to-address wide)
   "Like `message-reply'."
   (interactive)
   (gnus-setup-message 'message
-    (message-reply to-address wide)))
+    (message-reply to-address wide))
+  (and (boundp 'save-selected-window-window)
+       (not (window-live-p save-selected-window-window))
+       (setq save-selected-window-window (selected-window))))
 
 ;;;###autoload
 (define-mail-user-agent 'gnus-user-agent