Re: 2 wishes

[Shenghuo ZHU <zsh@cs.rochester.edu>]

>>>>> "LMI" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

LMI> zsh@cs.rochester.edu (Öìʤ»ð) writes:
>> 1. gnus-mime-inline-part toggles the inline part.
>> 
>> Press "i" on mime button, the part shows. Press again, the part hides
>> instead of showing two copies.

LMI> Do you mean that it should do this, or that this is what it does,
LMI> and that's a bug?

I thought it was not a bug. Unfortunately, it is. A patch attached.

>> 2. make uu parts shown as mime buttons.

LMI> Yes, that would be nice, but I think we should get the real MIME
LMI> things under control first.

I've made postscript parts and uuencoded parts shown as (MIME)
buttons. I am going to add "shar" and "binhex". When it is finished, I
will mail it to you.

What I did are
1. use gnus-article-display-hook 
2. elisp native uudecode function (steal lots code from base64.el)
3. modify mm-decode-content-transfer-encoding so that MIME button can
invoke uudecode. The following codes are the modified version. Any
suggestion?


(defun mm-decode-content-transfer-encoding (encoding)
  (cond
   ((eq encoding 'quoted-printable)
    (quoted-printable-decode-region (point-min) (point-max)))
   ((eq encoding 'base64)
    (condition-case ()
	(base64-decode-region (point-min) (point-max))
      (error nil)))
   ((memq encoding '(7bit 8bit binary))
    )
   ((null encoding)
    )
   ((fboundp encoding)                          ;;; modified
    (funcall encoding (point-min) (point-max))) ;;; modified
   (t
    (error "Can't decode encoding %s" encoding))))

-- 
Shenghuo

----------------------------------------------------------------
diff -ru pgnus-0.31/lisp/ChangeLog pgnus-0.32pre/lisp/ChangeLog
--- pgnus-0.31/lisp/ChangeLog	Mon Sep 14 12:55:34 1998
+++ pgnus-0.32pre/lisp/ChangeLog	Sun Sep 20 00:28:58 1998
@@ -1,3 +1,8 @@
+Sun Sep 20 00:27:55 1998  ZHU Shenghuo  <zsh@cs.rochester.edu>
+
+	* gnus-art.el (gnus-mime-inline-part): remove part if necessary
+	
+
 Mon Sep 14 18:55:38 1998  Lars Magne Ingebrigtsen  <larsi@menja.ifi.uio.no>
 
 	* gnus.el: Pterodactyl Gnus v0.31 is released.
diff -ru pgnus-0.31/lisp/gnus-art.el pgnus-0.32pre/lisp/gnus-art.el
--- pgnus-0.31/lisp/gnus-art.el	Mon Sep 14 12:55:35 1998
+++ pgnus-0.32pre/lisp/gnus-art.el	Sun Sep 20 00:29:39 1998
@@ -2199,9 +2199,11 @@
 	 (contents (mm-get-part data))
 	 (b (point))
 	 buffer-read-only)
-    (forward-line 2)
-    (mm-insert-inline data contents)
-    (goto-char b)))
+    (if (mm-handle-undisplayer data)
+	(mm-remove-part data)
+      (forward-line 2)
+      (mm-insert-inline data contents)
+      (goto-char b))))
 
 (defun gnus-insert-mime-button (handle)
   (let ((gnus-tmp-name (mail-content-type-get (mm-handle-type handle) 'name))