gnus-agent-fetch-session dies in 0.95

gnus-agent-fetch-session dies in 0.95

[Paul Stodghill]

I started using the agent this morning, and I have encountered the
following error intermittently throughout the day.

Signaling: (error "Selecting deleted or non-existent buffer")
  copy-to-buffer(#<killed buffer> 1 233)
  gnus-agent-fetch-headers("comp.emacs")
  gnus-agent-fetch-group-1("comp.emacs" (nntp "newsstand.cit.cornell.edu"))
  gnus-agent-fetch-session()
  (progn (gnus-agent-fetch-session))
)
  (if gnus-plugged (progn (gnus-agent-fetch-session)))
)
  (when gnus-plugged (gnus-agent-fetch-session))
)
  pvs-fetch-session-after-new-news()
  run-hooks(pvs-fetch-session-after-new-news)
  apply(run-hooks pvs-fetch-session-after-new-news)
  gnus-run-hooks(gnus-after-getting-new-news-hook)
  gnus-group-get-new-news(nil)
  call-interactively(gnus-group-get-new-news)

I am not sure what is triggering it, but once I encounter it, I have to
quit and restart Gnus to make it go away.

-- 
Paul Stodghill <stodghil@cs.cornell.edu>
Dept. of Computer Science, Upson Hall, Ithaca, NY  14853
Phone: 607-254-8838   FAX: 607-255-4428
http://www.cs.cornell.edu/stodghil/

Re: gnus-agent-fetch-session dies in 0.95

[Shenghuo ZHU]

[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]

>>>>> "Paul" == Paul Stodghill <stodghil@cs.cornell.edu> writes:

Paul> I started using the agent this morning, and I have encountered
Paul> the following error intermittently throughout the day.

Paul> Signaling: (error "Selecting deleted or non-existent buffer")
Paul>   copy-to-buffer(#<killed buffer> 1 233)
Paul>   gnus-agent-fetch-headers("comp.emacs")
Paul>   gnus-agent-fetch-group-1("comp.emacs" (nntp "newsstand.cit.cornell.edu"))
Paul>   gnus-agent-fetch-session()
Paul>   (progn (gnus-agent-fetch-session))
Paul> )
Paul>   (if gnus-plugged (progn (gnus-agent-fetch-session)))
Paul> )
Paul>   (when gnus-plugged (gnus-agent-fetch-session))
Paul> )
Paul>   pvs-fetch-session-after-new-news()
Paul>   run-hooks(pvs-fetch-session-after-new-news)
Paul>   apply(run-hooks pvs-fetch-session-after-new-news)
Paul>   gnus-run-hooks(gnus-after-getting-new-news-hook)
Paul>   gnus-group-get-new-news(nil)
Paul>   call-interactively(gnus-group-get-new-news)

Paul> I am not sure what is triggering it, but once I encounter it, I
Paul> have to quit and restart Gnus to make it go away.

I had encountered this before (using batch-fetch). When I set a trap,
it never happened again. OK, now I get your backtrace.

You probably use more than one nntp server.  I guess you lose
connection to one nntp server (probably not newsstand.cit.cornell.edu)

If my guess is right, the reason is that gnus-agent uses
gnus-agent-overview-buffer as nntp-server-buffer.  When gnus can not
connect a nntp server, the buffer is killed.

,-------- Line 959, file gnus-agent.el
|       (let ((nntp-server-buffer gnus-agent-overview-buffer))
| 	(setq gnus-newsgroup-headers
| 	      (gnus-get-newsgroup-headers-xover articles nil nil group)))
`--------

Anyway, try this patch.

1999-07-12  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* gnus-agent.el (gnus-agent-fetch-group-1): Recreate agent
 	overview buffer if it is killed.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 95-zsh4.diff --]
[-- Type: text/x-patch, Size: 1827 bytes --]

--- gnus-agent.el	1999/07/13 01:54:14	1.1
+++ gnus-agent.el	1999/07/13 02:02:32
@@ -949,16 +949,27 @@
 	category predicate info marks score-param)
     ;; Fetch headers.
     (when (and (or (gnus-active group) (gnus-activate-group group))
-	       (setq articles (gnus-agent-fetch-headers group)))
-      ;; Parse them and see which articles we want to fetch.
-      (setq gnus-newsgroup-dependencies
-	    (make-vector (length articles) 0))
-      ;; No need to call `gnus-get-newsgroup-headers-xover' with
-      ;; the entire .overview for group as we still have the just
-      ;; downloaded headers in `gnus-agent-overview-buffer'.
-      (let ((nntp-server-buffer gnus-agent-overview-buffer))
-	(setq gnus-newsgroup-headers
-	      (gnus-get-newsgroup-headers-xover articles nil nil group)))
+	       (setq articles (gnus-agent-fetch-headers group))
+	       (progn
+		 ;; Parse them and see which articles we want to fetch.
+		 (setq gnus-newsgroup-dependencies
+		       (make-vector (length articles) 0))
+		 ;; No need to call `gnus-get-newsgroup-headers-xover' with
+		 ;; the entire .overview for group as we still have the just
+		 ;; downloaded headers in `gnus-agent-overview-buffer'.
+		 (let ((nntp-server-buffer gnus-agent-overview-buffer))
+		   (setq gnus-newsgroup-headers
+			 (gnus-get-newsgroup-headers-xover articles nil nil 
+							   group)))
+		 ;; `gnus-agent-overview-buffer' may be killed for
+		 ;; timeout reason. If so, recreate it.
+		 (if (gnus-buffer-live-p gnus-agent-overview-buffer)
+		     t
+		   (setq gnus-agent-overview-buffer
+			 (gnus-get-buffer-create " *Gnus agent overview*"))
+		   (with-current-buffer gnus-agent-overview-buffer
+		     (mm-enable-multibyte))
+		   nil)))
       (setq category (gnus-group-category group))
       (setq predicate
 	    (gnus-get-predicate

[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


-- 
Shenghuo ZHU

Re: gnus-agent-fetch-session dies in 0.95

[Paul Stodghill]

>>>>> "ZSH" == Shenghuo ZHU <zsh@cs.rochester.edu> writes:

    ZSH> You probably use more than one nntp server. I guess you lose
    ZSH> connection to one nntp server (probably not
    ZSH> newsstand.cit.cornell.edu)

Yes, I am using two nntp servers. I think that your diagnosis is correct.

    ZSH> Anyway, try this patch.

So far so good. I'll let you know if I encounter any further problems.

Thank you!

-- 
Paul Stodghill <stodghil@cs.cornell.edu>
Dept. of Computer Science, Upson Hall, Ithaca, NY  14853
Phone: 607-254-8838   FAX: 607-255-4428
http://www.cs.cornell.edu/stodghil/